Page MenuHomePhabricator
Create Task
Maniphest T177080

MenuLayout rewrite broke VE's link inspector
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Commit https://gerrit.wikimedia.org/r/#/c/380586/ by @matmarex

Results in this extra margin in VE's link inspector:

image.png (373×409 px, 14 KB)

Also in score:

image.png (313×411 px, 14 KB)

Citoid is unaffected:

image.png (199×409 px, 14 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Set padded=false for link inspectormediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to master (84ec68dfb)mediawiki/extensions/VisualEditormaster+1 -1
Set padded=false for citoid inspectormediawiki/extensions/Citoidmaster+1 -5
Set padded=false for score inspectormediawiki/extensions/Scoremaster+1 -1
Make a clear API for setting inspector paddingVisualEditor/VisualEditormaster+9 -6
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 29 2017, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2017, 2:56 PM
Esanders triaged this task as High priority.Sep 29 2017, 2:56 PM
gerritbot subscribed.Sep 29 2017, 3:12 PM

Change 381455 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Make a clear API for setting inspector padding

https://gerrit.wikimedia.org/r/381455

gerritbot added a project: Patch-For-Review.Sep 29 2017, 3:12 PM
gerritbot added a comment.Sep 29 2017, 3:15 PM

Change 381457 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Set padded=false for link inspector

https://gerrit.wikimedia.org/r/381457

gerritbot added a comment.Sep 29 2017, 3:17 PM

Change 381458 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Citoid@master] Set padded=false for citoid inspector

https://gerrit.wikimedia.org/r/381458

gerritbot added a comment.Sep 29 2017, 3:18 PM

Change 381459 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Score@master] Set padded=false for score inspector

https://gerrit.wikimedia.org/r/381459

gerritbot added a comment.Sep 29 2017, 4:01 PM

Change 381455 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make a clear API for setting inspector padding

https://gerrit.wikimedia.org/r/381455

gerritbot added a comment.Sep 29 2017, 4:27 PM

Change 381269 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (84ec68dfb)

https://gerrit.wikimedia.org/r/381269

gerritbot added a comment.Sep 29 2017, 4:39 PM

Change 381269 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (84ec68dfb)

https://gerrit.wikimedia.org/r/381269

gerritbot added a comment.Sep 29 2017, 4:42 PM

Change 381457 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Set padded=false for link inspector

https://gerrit.wikimedia.org/r/381457

gerritbot added a comment.Sep 29 2017, 4:42 PM

Change 381459 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Set padded=false for score inspector

https://gerrit.wikimedia.org/r/381459

gerritbot added a comment.Sep 29 2017, 4:42 PM

Change 381458 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Set padded=false for citoid inspector

https://gerrit.wikimedia.org/r/381458

Jdforrester-WMF closed this task as Resolved.Sep 29 2017, 5:17 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 29 2017, 5:17 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 29 2017, 5:17 PM
Esanders merged a task: T176993: [Regression pre wmf.2] There is some extra padding appearing on the inside of the link inspector..Sep 29 2017, 9:44 PM
Esanders added subscribers: Ryasmeen, • Deskana.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Oct 2 2017, 11:54 PM
Ryasmeen added a project: Verified.Oct 3 2017, 7:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits