| Nikerabbit | |
| Sep 30 2017, 10:37 AM |
| F10019998: image.png | |
| Oct 5 2017, 5:22 PM |
Please compare Special:Translate using https://gerrit.wikimedia.org/r/381528 with $wgUsejQueryThree = false;, with $wgUsejQueryThree = true; and with $wgUsejQueryThree = true; and the migrate plugin temporarily disabled.
With the middle option, the shortcut tips shown when ALT button is hold down are mispositioned.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix editor shortcuts not showing up | mediawiki/extensions/Translate | master | +9 -14 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T169385 jQuery 3 migration warnings | |||
| Resolved | Nikerabbit | T177136 Translate editor shortcut indicators incorrectly positioned after fixing jQuery Migrate warning |
I just realized the patch was incorrect. Now the position is incorrect with all three of those. But I don't really understand why. I would expect the top-left corner of the elements to match (ignoring the negative margins of the absolutely positioned elements).
Change 381528 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Fix editor shortcuts not showing up
After I got rid of negative margins and instead manipulated the offset directly it again seems to work okay.
Here is a screenshot how they looked like before they got broken (1, 2, up, down; no example of insertables here):
Change 381528 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix editor shortcuts not showing up