Page MenuHomePhabricator

VisualEditor XML-style extension tag editor widget does not listen to changes in parameter fields
Closed, ResolvedPublic1 Estimate Story Points

Description

Steps to reproduce:

  • create a page with an extension tag for which VisualEditor does not have special logic, and which has some parameter (e.g. <templatestyles src="Foo"></templatestyles> - avoid self-closing syntax which is handled more incorrectly (T177180))
  • edit the page in VE
  • click on the extension tag (<> icon) then the Edit button
  • edit the src field

The "Done" button will not become active - apparently it only listens to changes in the main content, not in the parameters.

See also:

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterMWAlienExtensionNode: Listen to attribute changes

Event Timeline

Tgr created this task.Oct 1 2017, 10:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2017, 10:02 PM
Tgr updated the task description. (Show Details)Oct 1 2017, 10:04 PM

Change 381786 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWAlienExtensionNode: Listen to attribute changes

https://gerrit.wikimedia.org/r/381786

Jdforrester-WMF closed this task as Resolved.Oct 2 2017, 5:14 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 2 2017, 5:14 PM

Change 381786 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWAlienExtensionNode: Listen to attribute changes

https://gerrit.wikimedia.org/r/381786