Page MenuHomePhabricator

VisualEditor handles XML-style extension tags with no content incorrectly
Closed, ResolvedPublic1 Estimate Story Points

Description

Steps to reproduce:

  • create a page with an extension tag for which VisualEditor does not have special logic, (e.g. <templatestyles src="Foo">xxx</templatestyles>)
  • edit the page in VE
  • click on the extension tag (<> icon) then the Edit button
  • delete the content ("xxx")
  • click on "Done"

The extension tag will be removed. While there are extension tags for which an empty content is conceptually the same as the tag not being there at all, this is generally not a safe or reasonable assumption.

See also:

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterMWAlienExtensionNode: Listen to attribute changes

Event Timeline

Tgr created this task.Oct 1 2017, 10:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2017, 10:09 PM

Change 381786 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWAlienExtensionNode: Listen to attribute changes

https://gerrit.wikimedia.org/r/381786

Jdforrester-WMF closed this task as Resolved.Oct 2 2017, 5:15 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 2 2017, 5:15 PM

Change 381786 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWAlienExtensionNode: Listen to attribute changes

https://gerrit.wikimedia.org/r/381786