[mediawiki-api] Warnings from upload result are not logged
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwilson
	Oct 2 2017, 6:00 AM

Description

Some types of result don't have a top-level warnings element, but instead might have it one level down. For example, a duplicate upload can result in:

Array
(
    [upload] => Array
        (
            [result] => Warning
            [warnings] => Array
                (
                    [duplicate-archive] => Test.jpg
                )
            [filekey] => 157pzg7r75j4.bs0wl9.15.jpg
            [sessionkey] => 157pzg7r75j4.bs0wl9.15.jpg
        )

)

MediawikiApi::logWarnings() only currently looks for the top-level warnings.

(Google Code-In link: https://codein.withgoogle.com/dashboard/task-instances/6354431006212096 )

Event Timeline

Samwilson created this task.Oct 2 2017, 6:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2017, 6:00 AM

As this is a core mediawiki api module we can / should probably add handling for this in the library! :)

This might be a good easy Code-In task for later this year.

In T177191#3652496, @Samwilson wrote:

This might be a good easy Code-In task for later this year.

Would you volunteer mentoring?

@Aklapper yes sure!

@Samwilson: Thanks! Feel free to add your name and see the usual fine print. :)

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Nov 20 2017, 1:34 PM

@Samwilson should MediawikiApi::logWarnings() look for warnings recursively? Or maybe look firstly on the top level, then go deeper? I think that:

Check first level
Check deeper levels (recursively)

would be a fine approach. What do you think?

It could check recursively, but that might end up being a long-ish operation if the result set doesn't have any warnings and instead just has lots of results. It's probably okay to just check the first and second levels, because I don't think there's any API result which has warnings any deeper than that — it'd be worth confirming that though.

Thanks for claiming this task!

Samwilson updated the task description. (Show Details)Dec 18 2017, 9:33 PM

In T177191#3846328, @Samwilson wrote:

It could check recursively, but that might end up being a long-ish operation if the result set doesn't have any warnings and instead just has lots of results. It's probably okay to just check the first and second levels, because I don't think there's any API result which has warnings any deeper than that — it'd be worth confirming that though.

Yes, I think first and second levels could be good.

It has been fixed here: https://github.com/addwiki/mediawiki-api-base/pull/41

[mediawiki-api] Warnings from upload result are not loggedClosed, ResolvedPublicActions

Description

Event Timeline

[mediawiki-api] Warnings from upload result are not logged
Closed, ResolvedPublic
Actions