Page MenuHomePhabricator

Clicking to the left of a table that is the first node in the document twice misplaces the cursor
Closed, DuplicatePublic1 Estimated Story Points

Description

https://gerrit.wikimedia.org/r/#/c/381805/ fixes the common problem with clicking to the left of a table or other similar block node. However, if the table is the first node in the document, the first click to the left of it will (correctly) focus the preceding block-slug, and the second click to the left of it will place the cursor in an invalid position directly to the left of the table.

The problem seems to be that the native selection *does* change, but various optimizations within selection-setting code combine to assume that it hasn't and so there's no need to update it to match the model.

The correct behavior would be to just maintain the selection on the block-slug.

Event Timeline

Similarly if it is the last node, click to the right twice places the cursor in the trailing slug.

Deskana set the point value for this task to 1.
Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Deskana lowered the priority of this task from Medium to Low.Aug 30 2018, 10:02 AM
Deskana moved this task from TR0: Interrupt to Freezer on the VisualEditor board.

I can't reproduce anymore. It seems the issue was rediscovered and fixed as T201599.