Page MenuHomePhabricator

Decide whether we want to move phpcs.xml to .phpcs.xml
Closed, ResolvedPublic

Description

phpcs.xml files can now be prefixed with a dot to make them hidden files. Many of our current test configuration systems support this (e.g. .eslintrc, .stylelintrc, .jshintrc, .rubocop.yml), but others don't (phpunit.xml, Gruntfile.js, ...). Should we move phpcs.xml to .phpcs.xml as part of the upgrade to CodeSniffer 3.1.0?

CC'd a bunch of people who I think might have opinions :)

Related Objects

Mentioned In
rGTWNedc761a1e5c6: build: Updating dependencies
rEGGA96f89b353372: build: Updating mediawiki/mediawiki-codesniffer to 28.0.0
R2145:2fbf21a666a9: Move phpcs.xml to .phpcs.xml
rESRDc34f9f81e2cd: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rMLEQ9d83333c00d4: build: Updating mediawiki/mediawiki-codesniffer to 16.0.0
T161097: Recitation should include the article title
T172523: Add validation to input json in API
T175810: Add lexicon tool special page in Wikispeech extension
rEMOOC13ee65d2d00c: Move phpcs.xml to .phpcs.xml
rEMOOCd32ded23a59d: Move phpcs.xml to .phpcs.xml
rEWPE66b25ebae869: Move phpcs.xml to .phpcs.xml
rEWSO0c1ac20b1d28: Move phpcs.xml to .phpcs.xml
rEOLY16c7af885a06: Move phpcs.xml to .phpcs.xml
rEGNE0792c0fe1f05: Move phpcs.xml to .phpcs.xml
rEBOP3a7ff340f709: Move phpcs.xml to .phpcs.xml
R1985:d16c7c7234cd: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
R1984:5053579dc2cf: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rCSSS09eb61fc4666: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEUCA55d667a5c6b5: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEQSf8f7edade67e: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rENUAC977727217adb: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rETHR9a369b72541c: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
R1981:f17e0d601f71: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEIDS5eb732bcbce2: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rTAWRecdc0d18c404: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEBHK3080a0ce08b0: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rENPU64977f53a6b3: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rECKT40f4325bd5aa: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEDAH6c3a7bd9efad: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rERLS7c9d645a6128: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEXFAe3874e1bc080: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEEMAcbe6f6b28d85: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEMEM3e6fdf08ddd4: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEPPUe0d0a3174a45: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEULKc732037f1a5d: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rESHM8e286529ceeb: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rSVEV0b751cd044e3: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEWIS551ec230bbb9: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rETSTbe81f3de99be: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rESCCab56cd994cdf: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rERSL908b7c808b37: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEPIbed66c9d8285: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rELGN808f138c5b64: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEEPS9669eed34077: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rECWcc041d4bc155: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEARA4f377f1f1215: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
R1907:c61c9e845ba2: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rELINT27cf5913e028: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rLLUP2fbf21a666a9: Move phpcs.xml to .phpcs.xml
Mentioned Here
rEWIS01f254d951c7: Add lexicon tool special page in Wikispeech extension
rEWIScdda3ee55ad8: build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
rEWISe559d7521f36: Add specialpage alias for WikispeechLexiconTool
rEWIS551ec230bbb9: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEWIS6993ef482050: Validate value of API parameter "removetags"
rEWIS8824cf833b1b: build: Add MinusX
rEWIS3dd8daf29db5: Recite article title
rEWIS1929c0694e2e: build: Always exclude node_modules
T161097: Recitation should include the article title
T172523: Add validation to input json in API
T175810: Add lexicon tool special page in Wikispeech extension

Event Timeline

+1 to moving the file to a .phpcs.xml

I love the upstream issue title:

Consider adding leading dot to config files for visibility

When a file has a leading dot, it is hidden from ls which hmm... goes against visibility? :-)

+1 for .phpcs.xml

Change 385505 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/libraryupgrader@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385505

Change 385505 merged by jenkins-bot:
[labs/libraryupgrader@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385505

Legoktm claimed this task.

libraryupgrader will automatically move files during the next upgrade.

Change 385770 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385770

Change 385770 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385770