Page MenuHomePhabricator
Create Task
Maniphest T177256

Decide whether we want to move phpcs.xml to .phpcs.xml
Closed, ResolvedPublic
Actions

Description

phpcs.xml files can now be prefixed with a dot to make them hidden files. Many of our current test configuration systems support this (e.g. .eslintrc, .stylelintrc, .jshintrc, .rubocop.yml), but others don't (phpunit.xml, Gruntfile.js, ...). Should we move phpcs.xml to .phpcs.xml as part of the upgrade to CodeSniffer 3.1.0?

CC'd a bunch of people who I think might have opinions :)

Details

SubjectRepoBranchLines +/-
Move phpcs.xml to .phpcs.xmlmediawiki/tools/codesniffermaster+5 -5
Move phpcs.xml to .phpcs.xmllabs/libraryupgradermaster+23 -11
Customize query in gerrit

Related Objects

Mentioned In
rEFILEEXPORT0cef544b001e: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEOALdcca5348431b: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEEUS7fd1fc8d5058: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rGTWNedc761a1e5c6: build: Updating dependencies
rEGGA96f89b353372: build: Updating mediawiki/mediawiki-codesniffer to 28.0.0
R2145:2fbf21a666a9: Move phpcs.xml to .phpcs.xml
rESRDc34f9f81e2cd: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rMLEQ9d83333c00d4: build: Updating mediawiki/mediawiki-codesniffer to 16.0.0
T161097: Recitation should include the article title
T172523: Add validation to input json in API
T175810: Add lexicon tool special page in Wikispeech extension
rEMOOC13ee65d2d00c: Move phpcs.xml to .phpcs.xml
rEMOOCd32ded23a59d: Move phpcs.xml to .phpcs.xml
rEWPE66b25ebae869: Move phpcs.xml to .phpcs.xml
rEWSO0c1ac20b1d28: Move phpcs.xml to .phpcs.xml
rEOLY16c7af885a06: Move phpcs.xml to .phpcs.xml
rEGNE0792c0fe1f05: Move phpcs.xml to .phpcs.xml
rEBOP3a7ff340f709: Move phpcs.xml to .phpcs.xml
R1985:d16c7c7234cd: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
R1984:5053579dc2cf: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rCSSS09eb61fc4666: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEUCA55d667a5c6b5: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEQSf8f7edade67e: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rENUAC977727217adb: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rETHR9a369b72541c: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
R1981:f17e0d601f71: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEIDS5eb732bcbce2: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rTAWRecdc0d18c404: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEBHK3080a0ce08b0: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rENPU64977f53a6b3: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rECKT40f4325bd5aa: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEDAH6c3a7bd9efad: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rERLS7c9d645a6128: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEXFAe3874e1bc080: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEEMAcbe6f6b28d85: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEMEM3e6fdf08ddd4: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEPPUe0d0a3174a45: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEULKc732037f1a5d: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rESHM8e286529ceeb: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rSVEV0b751cd044e3: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEWIS551ec230bbb9: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rETSTbe81f3de99be: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rESCCab56cd994cdf: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rERSL908b7c808b37: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEPIbed66c9d8285: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rELGN808f138c5b64: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEEPS9669eed34077: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rECWcc041d4bc155: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEARA4f377f1f1215: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
R1907:c61c9e845ba2: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rELINT27cf5913e028: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rLLUP2fbf21a666a9: Move phpcs.xml to .phpcs.xml
Mentioned Here
rEWIS01f254d951c7: Add lexicon tool special page in Wikispeech extension
rEWIScdda3ee55ad8: build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
rEWISe559d7521f36: Add specialpage alias for WikispeechLexiconTool
rEWIS551ec230bbb9: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEWIS6993ef482050: Validate value of API parameter "removetags"
rEWIS8824cf833b1b: build: Add MinusX
rEWIS3dd8daf29db5: Recite article title
rEWIS1929c0694e2e: build: Always exclude node_modules
T161097: Recitation should include the article title
T172523: Add validation to input json in API
T175810: Add lexicon tool special page in Wikispeech extension

Event Timeline

Legoktm created this task.Oct 2 2017, 9:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2017, 9:49 PM
Paladox added a comment.EditedOct 2 2017, 9:52 PM

+1 to moving the file to a .phpcs.xml

Umherirrender added a comment.Oct 2 2017, 10:02 PM

Sounds good to me

Krinkle added a comment.Oct 2 2017, 10:12 PM

Looks good to me.

Samwilson added a comment.Oct 2 2017, 10:23 PM

Feels good to me.

Jdforrester-WMF awarded a token.Oct 2 2017, 10:58 PM
Addshore added a comment.Oct 3 2017, 7:32 AM

Tastes good to me

Addshore awarded a token.Oct 3 2017, 7:33 AM
Florian awarded a token.Oct 8 2017, 11:48 AM
hashar added a comment.Oct 12 2017, 8:40 AM

I love the upstream issue title:

Consider adding leading dot to config files for visibility

When a file has a leading dot, it is hidden from ls which hmm... goes against visibility? :-)

+1 for .phpcs.xml

gerritbot subscribed.Oct 21 2017, 2:53 AM

Change 385505 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/libraryupgrader@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385505

gerritbot added a project: Patch-For-Review.Oct 21 2017, 2:53 AM
Legoktm mentioned this in rLLUP2fbf21a666a9: Move phpcs.xml to .phpcs.xml.Oct 21 2017, 2:53 AM
gerritbot added a comment.Oct 21 2017, 2:53 AM

Change 385505 merged by jenkins-bot:
[labs/libraryupgrader@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385505

Diffusion mentioned this in rELINT27cf5913e028: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 3:01 AM
Legoktm closed this task as Resolved.Oct 21 2017, 3:24 AM
Legoktm claimed this task.

libraryupgrader will automatically move files during the next upgrade.

Diffusion mentioned this in R1907:c61c9e845ba2: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 3:50 AM
Diffusion mentioned this in rEARA4f377f1f1215: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:17 AM
Diffusion mentioned this in rECWcc041d4bc155: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:20 AM
Diffusion mentioned this in rEEPS9669eed34077: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in rELGN808f138c5b64: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:26 AM
Diffusion mentioned this in rEPIbed66c9d8285: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:28 AM
Diffusion mentioned this in rERSL908b7c808b37: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in rESCCab56cd994cdf: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:33 AM
Diffusion mentioned this in rETSTbe81f3de99be: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in rEWIS551ec230bbb9: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:36 AM
Diffusion mentioned this in rSVEV0b751cd044e3: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:39 AM
Diffusion mentioned this in rESHM8e286529ceeb: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in rEULKc732037f1a5d: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:49 AM
Diffusion mentioned this in rEPPUe0d0a3174a45: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 4:59 AM
Diffusion mentioned this in rEMEM3e6fdf08ddd4: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:02 AM
Diffusion mentioned this in rEEMAcbe6f6b28d85: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:05 AM
Diffusion mentioned this in rEXFAe3874e1bc080: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in rERLS7c9d645a6128: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:07 AM
Diffusion mentioned this in rEDAH6c3a7bd9efad: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:15 AM
Diffusion mentioned this in rECKT40f4325bd5aa: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:23 AM
Diffusion mentioned this in rENPU64977f53a6b3: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in rEBHK3080a0ce08b0: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:26 AM
Diffusion mentioned this in rTAWRecdc0d18c404: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:36 AM
Diffusion mentioned this in rEIDS5eb732bcbce2: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:42 AM
Diffusion mentioned this in R1981:f17e0d601f71: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:45 AM
Diffusion mentioned this in rETHR9a369b72541c: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 5:49 AM
Diffusion mentioned this in rENUAC977727217adb: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 6:01 AM
Diffusion mentioned this in rEQSf8f7edade67e: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 7:03 AM
Diffusion mentioned this in rEUCA55d667a5c6b5: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 7:13 AM
Diffusion mentioned this in rCSSS09eb61fc4666: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 7:31 AM
Diffusion mentioned this in R1984:5053579dc2cf: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.
Diffusion mentioned this in R1985:d16c7c7234cd: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Oct 21 2017, 7:54 AM
gerritbot added a comment.Oct 21 2017, 8:39 AM

Change 385770 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385770

Umherirrender mentioned this in rEBOP3a7ff340f709: Move phpcs.xml to .phpcs.xml.Oct 21 2017, 12:32 PM
Umherirrender mentioned this in rEGNE0792c0fe1f05: Move phpcs.xml to .phpcs.xml.Oct 21 2017, 12:37 PM
Umherirrender mentioned this in rEOLY16c7af885a06: Move phpcs.xml to .phpcs.xml.Oct 21 2017, 12:42 PM
Umherirrender mentioned this in rEWSO0c1ac20b1d28: Move phpcs.xml to .phpcs.xml.Oct 21 2017, 12:49 PM
gerritbot added a comment.Oct 21 2017, 4:48 PM

Change 385770 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Move phpcs.xml to .phpcs.xml

https://gerrit.wikimedia.org/r/385770

Umherirrender mentioned this in rEWPE66b25ebae869: Move phpcs.xml to .phpcs.xml.Nov 2 2017, 9:52 AM
Umherirrender mentioned this in rEMOOCd32ded23a59d: Move phpcs.xml to .phpcs.xml.Nov 2 2017, 11:25 AM
Umherirrender mentioned this in rEMOOC13ee65d2d00c: Move phpcs.xml to .phpcs.xml.Nov 2 2017, 11:34 AM
Stashbot mentioned this in T175810: Add lexicon tool special page in Wikispeech extension.Nov 28 2017, 1:44 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-cloud) [2017-11-28T13:44:40Z] <Sebastian-WMSE> Deploy latest from Git master: 01f254d (T175810), cdda3ee, e559d75, 551ec23 (T177256), 6993ef4 (T172523), 8824cf8, 3dd8daf (T161097), 1929c06

Stashbot mentioned this in T172523: Add validation to input json in API.Nov 28 2017, 1:44 PM
Stashbot mentioned this in T161097: Recitation should include the article title.
Diffusion mentioned this in rMLEQ9d83333c00d4: build: Updating mediawiki/mediawiki-codesniffer to 16.0.0.Feb 15 2018, 9:22 AM
Restricted Repository Identity mentioned this in rESRDc34f9f81e2cd: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.Jul 27 2019, 11:18 PM
Legoktm mentioned this in R2145:2fbf21a666a9: Move phpcs.xml to .phpcs.xml.Oct 20 2019, 6:40 PM
Restricted Repository Identity mentioned this in rEGGA96f89b353372: build: Updating mediawiki/mediawiki-codesniffer to 28.0.0.Oct 21 2019, 5:26 AM
jenkins-bot mentioned this in rGTWNedc761a1e5c6: build: Updating dependencies.Dec 14 2020, 8:36 AM
LibUp-bot mentioned this in rEEUS7fd1fc8d5058: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.May 25 2023, 5:57 PM
LibUp-bot mentioned this in rEOALdcca5348431b: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.May 25 2023, 6:04 PM
Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 6:10 PM
Umherirrender mentioned this in rEFILEEXPORT0cef544b001e: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0.May 25 2023, 6:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL