Page MenuHomePhabricator
Create Task
Maniphest T177259

Collection using deprecated global variables
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Start a new book and click "add this page to book"

Notice:

load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:154 Use of "wgNamespaceNumber" is deprecated. Use mw.config instead.
get @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:154
onclick @ W._J._Cash:53
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:154 Use of "wgTitle" is deprecated. Use mw.config instead.

It appears this is using globals. This will break soon (@Krinkle probably can inform us on when) and if that happens this feature will be broken.

Details

SubjectRepoBranchLines +/-
Stop using wgNamespace and wgTitle globalsmediawiki/extensions/Collectionmaster+8 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Oct 2 2017, 10:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2017, 10:40 PM
Jdlrobson triaged this task as High priority.Oct 2 2017, 10:40 PM
gerritbot subscribed.Oct 2 2017, 10:47 PM

Change 381892 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Stop using wgNamespace and wgTitle globals

https://gerrit.wikimedia.org/r/381892

gerritbot added a project: Patch-For-Review.Oct 2 2017, 10:47 PM
Krinkle added a parent task: T35837: Set $wgLegacyJavaScriptGlobals = false by default.Oct 2 2017, 11:19 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Oct 3 2017, 4:04 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Oct 10 2017, 12:25 PM
Jdlrobson set the point value for this task to 0.5.Oct 10 2017, 4:45 PM
Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.
Jdlrobson moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.
MBinder_WMF moved this task from 2017-18 Q1 to 2017-18 Q2 on the Web-Team-Backlog board.Oct 10 2017, 7:00 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 11 2017, 7:39 PM
• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Oct 12 2017, 6:57 PM
gerritbot added a comment.Oct 12 2017, 7:01 PM

Change 381892 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Stop using wgNamespace and wgTitle globals

https://gerrit.wikimedia.org/r/381892

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 12 2017, 8:00 PM
phuedx closed this task as Resolved.Oct 17 2017, 11:57 AM
phuedx claimed this task.
phuedx subscribed.

I don't see any warnings on Special:Book or on pages where the book creator banner is inserted 🎉🎉🎉

Krinkle mentioned this in T72470: Remove legacy javascript globals.Mar 7 2018, 8:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL