Page MenuHomePhabricator
Create Task
Maniphest T177261

Remove QuickSurveys browser tests written in Ruby
Closed, ResolvedPublic
Actions

Description

While working on T160238, I propose we split into groups for maximum effectiveness.
This task deals with the QuickSurveys extension.

  • Feature: Survey bucketing (opting in)
    • Scenario: Internal survey is visible when bucketed # tests/browser/features/bucketing.feature:14
    • Scenario: External survey is visible when bucketed # tests/browser/features/bucketing.feature:22
  • Feature: External surveys
    • Scenario: External survey is visible with flag #
    • Scenario: External survey is not present without flag when not bucketed
    • Scenario: External survey is not present when dismissed # tests/browser/features/external_survey.feature:21
    • Scenario: User can participate in external survey # tests/browser/features/external_survey.feature:27
  • Feature: Integration
    • Scenario: Survey is visible with quicksurvey=true flag # tests/browser/features/integration.feature:6
  • Feature: Internal surveys
    • Scenario: Internal survey has multiple answers #
    • Scenario: Internal survey is visible with flag #
    • Scenario: Internal survey is not present without flag
    • Scenario: Internal survey is not present when dismissed # tests/browser/features/internal_survey.feature:24
    • Scenario: User can participate in internal survey # tests/browser/features/internal_survey.feature:30

Notes

  1. The mw-wdio-nodepool builder replaces the mwext-ruby-jessie builder in integration-config/zuul/layout.yaml, which will make check experimental run the new WebdriverIO-based tests.
  2. Put your new tests in the tests/selenium/, following the example structure in RelatedArticles.

Developer notes

🏝 443111 (mediawiki/extensions/QuickSurveys): WIP The first sample Selenium test in Node.js

There are 4 files that need porting

  • bucketing.feature
  • external_survey.feature
  • integration.feature
  • internal_survey.feature

We'll probably want to follow the approach we've considered for Minerva and take the following steps

  • Port integration.feature (1 test) to Selenium and setup Ruby&Node.js browser tests side-by-side (T190710)
  • Port external_survey.feature
  • Port internal_survey.feature
  • Port bucketing.feature

Details

SubjectRepoBranchLines +/-
Selenium: Delete Ruby testsmediawiki/extensions/QuickSurveysmaster+0 -1 K
Delete Ruby jobs for QuickSurveysintegration/configmaster+0 -2
jjb: rm selenium-MinervaNeue and selenium-QuickSurveysintegration/configmaster+0 -71
WIP The first sample Selenium test in Node.jsmediawiki/extensions/QuickSurveysmaster+177 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Oct 2 2017, 11:30 PM
phuedx updated the task description. (Show Details)Oct 3 2017, 1:40 PM
phuedx updated the task description. (Show Details)Oct 3 2017, 1:45 PM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Oct 3 2017, 4:04 PM
Jdlrobson renamed this task from [subtask] Rewrite QuickSurveys browser tests in Node.js to [subtask] Rewrite QuickSurveys browser tests in Node.js or remove them.Oct 4 2017, 5:10 PM
Jdlrobson added a parent task: T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions.
Jdlrobson lowered the priority of this task from High to Medium.Oct 4 2017, 5:21 PM
Jdlrobson moved this task from Upcoming to Tracking on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.Oct 11 2017, 2:55 PM
Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Oct 23 2017, 6:09 PM
zeljkofilipin mentioned this in T139740: Port Selenium tests from Ruby to Node.js.Oct 30 2017, 12:09 PM
zeljkofilipin moved this task from Q4 👔 to Watching 📺 on the User-zeljkofilipin board.Nov 9 2017, 12:23 PM
zeljkofilipin removed a project: User-zeljkofilipin.Nov 10 2017, 3:23 PM
zeljkofilipin removed a parent task: T160238: Rewrite MobileFrontend and Page previews automated browser tests in Node.js.
phuedx renamed this task from [subtask] Rewrite QuickSurveys browser tests in Node.js or remove them to Rewrite QuickSurveys browser tests in Node.js or remove them.Nov 28 2017, 2:33 PM
phuedx added a subtask: T181509: [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack.
phuedx closed subtask T181509: [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack as Resolved.Nov 29 2017, 6:40 PM
• bmansurov unsubscribed.Dec 22 2017, 9:48 PM
zeljkofilipin mentioned this in T183160: Sample code in Node.js for repositories that still have Selenium+Ruby tests.Jun 28 2018, 2:57 PM
zeljkofilipin mentioned this in T183162: Patches in Gerrit deleting Selenium+Ruby tests for repositories that still have them.
zeljkofilipin mentioned this in T198409: Set up CI for running Node.js+Selenium tests for repositories that have Ruby+Selenium tests.Jun 28 2018, 4:02 PM
zeljkofilipin added a parent task: T183160: Sample code in Node.js for repositories that still have Selenium+Ruby tests.Jun 29 2018, 2:45 PM
zeljkofilipin claimed this task.Jun 29 2018, 3:38 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 29 2018, 3:38 PM
zeljkofilipin added a project: User-zeljkofilipin.Jun 29 2018, 3:38 PM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin lowered the priority of this task from Medium to Low.Jun 29 2018, 4:29 PM
gerritbot added a comment.Jun 29 2018, 4:35 PM

Change 443111 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/QuickSurveys@master] WIP The first sample Selenium test in Node.js

https://gerrit.wikimedia.org/r/443111

gerritbot added a project: Patch-For-Review.Jun 29 2018, 4:35 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Jun 29 2018, 4:41 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin mentioned this in rEQS8964ecd8ca08: WIP The first sample Selenium test in Node.js.Jun 29 2018, 4:41 PM
zeljkofilipin moved this task from In-progress to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.Jun 29 2018, 4:41 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.
zeljkofilipin removed a parent task: T183160: Sample code in Node.js for repositories that still have Selenium+Ruby tests.
gerritbot added a comment.Sep 4 2018, 11:14 AM

Change 443111 abandoned by Zfilipin:
WIP The first sample Selenium test in Node.js

Reason:
No activity in months.

https://gerrit.wikimedia.org/r/443111

zeljkofilipin removed a project: User-zeljkofilipin.Sep 19 2018, 10:21 AM
zeljkofilipin removed a project: Release-Engineering-Team (Kanban).Sep 25 2018, 10:07 AM
Jdlrobson renamed this task from Rewrite QuickSurveys browser tests in Node.js or remove them to Rewrite QuickSurveys browser tests in Node.js.Oct 16 2018, 9:37 PM
Jdlrobson raised the priority of this task from Low to Medium.
Jdlrobson mentioned this in T111472: QA: No browser tests covering QuickSurveys in mobile skin.
Jdlrobson updated the task description. (Show Details)Oct 16 2018, 9:44 PM

Many of the browser tests seem to repeat one another. I'm not sure if it makes sense to port all of them, but we can work that out as we take on this work.

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).Oct 16 2018, 9:45 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Oct 16 2018, 9:50 PM
Jdlrobson removed a project: Patch-For-Review.Oct 24 2018, 10:13 PM
Jdlrobson lowered the priority of this task from Medium to Low.Nov 15 2018, 6:53 PM
Jdlrobson moved this task from Backlog to Bugs on the QuickSurveys board.Jan 15 2019, 5:56 PM
hashar mentioned this in T225031: On CI Jenkins, audit worker labels and remove unused ones.Dec 10 2019, 2:13 PM
hashar added a parent task: T225031: On CI Jenkins, audit worker labels and remove unused ones.
hashar mentioned this in T236576: Move all Wikimedia CI (WMCS integration project) instances from jessie to stretch.
gerritbot added a comment.Dec 12 2019, 2:00 PM

Change 556252 had a related patch set uploaded (by Hashar; owner: Jforrester):
[integration/config@master] jjb: rm selenium-MinervaNeue and selenium-QuickSurveys

https://gerrit.wikimedia.org/r/556252

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 12 2019, 2:00 PM
gerritbot added a project: Patch-For-Review.Dec 12 2019, 2:00 PM

Change 556252 merged by jenkins-bot:
[integration/config@master] jjb: rm selenium-MinervaNeue and selenium-QuickSurveys

https://gerrit.wikimedia.org/r/556252

Jdlrobson removed a project: Patch-For-Review.Jan 7 2020, 3:19 PM
Jdlrobson added a subscriber: awight.Jun 9 2020, 4:57 PM
Jdlrobson added projects: Quality-and-Test-Engineering-Office-Hours, Quality-and-Test-Engineering-Team.Jun 9 2020, 5:01 PM
Jdlrobson added a subscriber: Edtadros.

@zeljkofilipin @Edtadros shall we remove the browser tests from QuickSurveys? IMO I'm not sure we're getting much benefit from the browser tests we have. That said maybe it's trivial to rewrite the tests we do have in Node.js

zeljkofilipin removed a project: Quality-and-Test-Engineering-Office-Hours.Jun 10 2020, 11:19 AM
zeljkofilipin added a project: User-zeljkofilipin.Jun 10 2020, 11:21 AM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.

@Jdlrobson it's not trivial to rewrite tests. If you think existing Ruby tests don't provide value, let's delete them.

@Edtadros what do you think?

gerritbot added a comment.Jun 10 2020, 2:26 PM

Change 604402 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[mediawiki/extensions/QuickSurveys@master] Selenium: Delete Ruby tests

https://gerrit.wikimedia.org/r/604402

gerritbot added a project: Patch-For-Review.Jun 10 2020, 2:26 PM
gerritbot added a comment.Jun 10 2020, 2:58 PM

Change 604414 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[integration/config@master] Delete Ruby jobs for QuickSurveys

https://gerrit.wikimedia.org/r/604414

gerritbot added a comment.Jun 10 2020, 3:18 PM

Change 604414 merged by jenkins-bot:
[integration/config@master] Delete Ruby jobs for QuickSurveys

https://gerrit.wikimedia.org/r/604414

Stashbot added a comment.Jun 10 2020, 3:18 PM

Mentioned in SAL (#wikimedia-releng) [2020-06-10T15:18:41Z] <James_F> Zuul: [mediawiki/extensions/QuickSurveys] Stop running ruby jobs T177261

zeljkofilipin assigned this task to Edtadros.Jun 10 2020, 3:24 PM
zeljkofilipin moved this task from Waiting 🏹 to Learn/Teach 💡 on the User-zeljkofilipin board.
gerritbot added a comment.Jun 10 2020, 3:56 PM

Change 604402 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Selenium: Delete Ruby tests

https://gerrit.wikimedia.org/r/604402

Jdlrobson closed this task as Resolved.Jun 10 2020, 5:22 PM
Edtadros added a comment.Jun 10 2020, 5:35 PM

@Jdlrobson, after discussing this with @zeljkofilipin we decided the best course of action would be to remove them. I will set up some time to discuss how/if you would like to proceed with the QuickSurveys automation moving forward

Jdlrobson renamed this task from Rewrite QuickSurveys browser tests in Node.js to Remove QuickSurveys browser tests written in Ruby.Jun 10 2020, 6:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL