Page MenuHomePhabricator
Create Task
Maniphest T177303

Use server-side adaptation for categories in CX2
Closed, ResolvedPublic
Actions

Description

CX2 still uses client-side adaptation for categories. It should use the <meta> tags that are already provided in the server-side adaptation, and stick those into the VE DM so the built-in VE category editor can edit them.

Details

SubjectRepoBranchLines +/-
More tests and fixes for section wrapsmediawiki/services/cxservermaster+53 -30
Use categories adapted on servermediawiki/extensions/ContentTranslationmaster+24 -45
CX2: Use the new page fetch apimediawiki/extensions/ContentTranslationmaster+6 -4
Extract and expose categories in page APImediawiki/services/cxservermaster+183 -46
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT188605 CX2: Category support
 Resolved• santhoshT177303 Use server-side adaptation for categories in CX2

Event Timeline

Catrope created this task.Oct 3 2017, 5:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2017, 5:47 PM
Catrope moved this task from Needs Triage to CX2 on the ContentTranslation board.Oct 3 2017, 5:47 PM
Catrope mentioned this in T150652: Content Translation feature parity checklist post VisualEditor integration.
Arrbee added projects: Language-2017-Oct-Dec, Language-2017-July-Sept.Oct 4 2017, 3:16 PM
Arrbee moved this task from Backlog to In Review on the Language-2017-Oct-Dec board.
Arrbee moved this task from Backlog to In Review on the Language-2017-July-Sept board.
Arrbee moved this task from In Review to Continued/Moved to future on the Language-2017-July-Sept board.Oct 4 2017, 3:22 PM
Arrbee assigned this task to Catrope.Oct 11 2017, 7:18 AM
gerritbot subscribed.Nov 7 2017, 5:43 PM

Change 389751 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/services/cxserver@master] [WIP] Extract and expose categories in page API

https://gerrit.wikimedia.org/r/389751

gerritbot added a project: Patch-For-Review.Nov 7 2017, 5:43 PM
Nikerabbit moved this task from In Review to In Progress on the Language-2017-Oct-Dec board.Nov 15 2017, 7:05 AM
Arrbee moved this task from In Progress to Continued/Moved to future on the Language-2017-Oct-Dec board.Jan 3 2018, 11:24 AM
Arrbee added a project: Language-2018-Jan-Mar.Jan 5 2018, 1:02 PM
Arrbee moved this task from Backlog to In Progress on the Language-2018-Jan-Mar board.
Arrbee moved this task from CX2 to April-June 2018 on the ContentTranslation board.Jan 5 2018, 1:14 PM
Arrbee removed Catrope as the assignee of this task.Feb 8 2018, 9:37 AM
Arrbee subscribed.

@Catrope is moving to other project priority and this task is now not assigned to him any more.

• santhosh claimed this task.Feb 16 2018, 12:35 PM
• santhosh removed projects: Language-2017-July-Sept, Language-2017-Oct-Dec.
Pginer-WMF triaged this task as Medium priority.Feb 20 2018, 7:14 AM
• santhosh moved this task from In Progress to In Review on the Language-2018-Jan-Mar board.Feb 26 2018, 7:01 AM
gerritbot added a comment.Feb 27 2018, 6:58 AM

Change 414952 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Use the new page fetch api

https://gerrit.wikimedia.org/r/414952

• Petar.petkovic subscribed.Feb 28 2018, 10:01 AM
Pginer-WMF mentioned this in T188605: CX2: Category support.Mar 1 2018, 10:41 AM
Pginer-WMF added a parent task: T188605: CX2: Category support.Mar 1 2018, 12:02 PM
Pginer-WMF mentioned this in T188614: CX2: Support users to adjust category mapping.Mar 1 2018, 12:26 PM
Pginer-WMF mentioned this in T188615: CX2: Allow users to add new categories of their choice.Mar 1 2018, 12:36 PM
gerritbot added a comment.Mar 6 2018, 3:11 PM

Change 389751 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Extract and expose categories in page API

https://gerrit.wikimedia.org/r/389751

gerritbot added a comment.Mar 6 2018, 3:24 PM

Change 414952 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Use the new page fetch api

https://gerrit.wikimedia.org/r/414952

Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.Mar 6 2018, 3:26 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 4:00 PM
• Petar.petkovic removed a project: Patch-For-Review.Mar 6 2018, 4:01 PM
gerritbot added a comment.Mar 6 2018, 10:30 PM

Change 416847 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Use categories adapted on server

https://gerrit.wikimedia.org/r/416847

gerritbot added a project: Patch-For-Review.Mar 6 2018, 10:30 PM
• Petar.petkovic moved this task from QA to In Review on the Language-2018-Jan-Mar board.Mar 6 2018, 10:31 PM
gerritbot added a comment.Mar 7 2018, 6:16 AM

Change 416674 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] More tests and fixes for section wraps

https://gerrit.wikimedia.org/r/416674

gerritbot added a comment.Mar 7 2018, 9:46 AM

Change 416847 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use categories adapted on server

https://gerrit.wikimedia.org/r/416847

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)); removed MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 7 2018, 10:00 AM
• Petar.petkovic removed a project: Patch-For-Review.Mar 7 2018, 10:42 AM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-Jan-Mar board.
gerritbot added a comment.Mar 8 2018, 7:34 AM

Change 416674 merged by jenkins-bot:
[mediawiki/services/cxserver@master] More tests and fixes for section wraps

https://gerrit.wikimedia.org/r/416674

KartikMistry moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 8 2018, 11:04 AM
KartikMistry subscribed.Mar 8 2018, 11:06 AM

I'll wait till cxserver is deployed in production before closing, but everything seems OK related to category adaption.

Pginer-WMF mentioned this in T189632: CX2: Avoid gaps below the category controls when they have different height.Mar 14 2018, 12:55 PM
KartikMistry closed this task as Resolved.Mar 15 2018, 2:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL