Page MenuHomePhabricator

[epic] Wikipedia.org portal images: SVG vs PNG and other issues
Closed, ResolvedPublic

Description

This is a collection of tickets that need to be discussed, finished and/or cleaned up before we can fully automate the Wikipedia.org portal updates.

  • T129634 Discuss SVG usage on wikipedia.org (see T129634#2111363)
  • T164929: Search icon of Wikipedia homepage looks a little odd
  • T152386: CI tests on wikimedia/portals repo: cache node_modules to save time (moved to backlog)
  • T146408: Portal sister project icons are inconsistent sizes (moved to backlog)

Notes from an earlier discussion between @Jdrewniak and @debt:
Images - optimizes all image and combines into one to push to prod - if we optimize the SVG’s we won’t do this step - and it’ll result in more HTTP requests, might slow down the page a tiny bit

  • SVG - should we get that working properly?
  • We can’t use all svg’s - some are just too big (wiki logo, Wikinews logo)
  • Maybe combine all SVG and all PNG?
  • Find a tool?
  • Might help with the installation on tool labs
    • Need to remove those dependancies
    • NPM installs is what is failing
      • First known issue
    • Will need to create or modify this tool for images
    • Currently using Jan’s Gerrit key and credentials
      • Would need to get Gerrit credentials for this newly created tool

Event Timeline

Change 384563 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] [WIP] Replacing portal image workflow with SVGs

https://gerrit.wikimedia.org/r/384563

Change 387193 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] SVG Sprites - Replacing PNG images with SVG sprite in the HTML

https://gerrit.wikimedia.org/r/387193

Change 387194 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] SVG Sprites - Removing old gulp tasks & npm deps

https://gerrit.wikimedia.org/r/387194

Change 384563 abandoned by Jdrewniak:
Replacing portal image workflow with SVGs

Reason:
As per @Volker's suggestion. I've split this patch into multiple commits on the following topic thread

https://gerrit.wikimedia.org/r/#/q/topic:new-svg-sprites (status:open OR status:merged)

https://gerrit.wikimedia.org/r/384563

Change 387193 merged by jenkins-bot:
[wikimedia/portals@master] SVG Sprites - Replacing PNG images with SVG sprite in the HTML

https://gerrit.wikimedia.org/r/387193

Volker_E renamed this task from [epic] Wikipedia.org portal images: svg vs png and other issues to [epic] Wikipedia.org portal images: SVG vs PNG and other issues.Nov 8 2017, 9:24 PM

Change 387194 merged by jenkins-bot:
[wikimedia/portals@master] SVG Sprites - Remove old gulp tasks & npm deps

https://gerrit.wikimedia.org/r/387194

debt updated the task description. (Show Details)
debt removed a project: Patch-For-Review.
debt updated the task description. (Show Details)
debt moved this task from Backlog to Done on the Discovery-Portal-Sprint board.