Page MenuHomePhabricator
Create Task
Maniphest T177360

[Bug] Article cells are backwards for RTL languages
Closed, ResolvedPublic
Actions

Description

Simulator Screen Shot - iPhone X - 2017-10-03 at 16.51.40.png (1×2 px, 277 KB)

Steps to reproduce

  1. Switch device language to Hebrew
  2. Install the app with Hebrew wikipedia as your only language
  3. Open the app, tap the search icon
  4. Enter text, tap search
  5. Verify cell layout direction
  6. Tap an article
  7. Tap search, tap clear
  8. Verify recent search layout direction

Expected result
Article cells and recent search cells are right aligned

Actual result
Article cells and recent search cells are left aligned

Notes
Recent search alignment will match device language (for example, even if you search enwiki using the english keyboard, the recent search entry will be right aligned if your system language is hebrew)
Search result alignment should match article language (left aligned for enwiki, right aligned for hewiki)

Event Timeline

cmadeo created this task.Oct 3 2017, 11:54 PM
Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptOct 3 2017, 11:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
cmadeo closed this task as Invalid.Oct 3 2017, 11:56 PM

I had the English keyboard up, this works fine with the Arabic keyboard!

JoeWalsh reopened this task as Open.EditedOct 4 2017, 11:35 AM
JoeWalsh claimed this task.
JoeWalsh moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.
JoeWalsh subscribed.

The text field is fine, but the cells are backwards. Re-opening this bug to fix that issue (since the screenshot already illustrates the problem)

JoeWalsh renamed this task from [Bug] Text appearing from wrong side in RTL languages in search field to [Bug] Article cells are backwards for RTL languages.Oct 4 2017, 11:37 AM
JoeWalsh updated the task description. (Show Details)

Expected behavior:

Simulator Screen Shot - iPhone X - 2017-10-04 at 07.34.12.png (2×1 px, 150 KB)

Simulator Screen Shot - iPhone X - 2017-10-04 at 07.34.16.png (2×1 px, 326 KB)

JoeWalsh updated the task description. (Show Details)Oct 4 2017, 11:41 AM
• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 4 2017, 2:42 PM
cmadeo added a comment.Oct 4 2017, 4:18 PM

@JoeWalsh thanks for re-opening this! Can't believe I missed the backwards cells!

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 10 2017, 7:16 PM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 12 2017, 9:07 PM

Looks good!

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 13 2017, 9:39 PM
ABorbaWMF subscribed.

Works on iPhone X on Beta 5.7.1 (1244)

Looks to me. I was wondering if the same logic should apply the search view and list view in places? The images/icons on those views are currently on the right. @cmadeo, What do you think?

cmadeo added a comment.Oct 13 2017, 11:51 PM

@ABorbaWMF, good catch! @JoeWalsh how hard would it be to have this logic apply to the list view in Places?

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Oct 30 2017, 9:59 PM
• JMinor added a project: ios-app-v5.7.1-Corgi-On-Nothing.
• JMinor subscribed.

Moving to 5.7.1 to discuss Places.

• JMinor triaged this task as Low priority.Oct 30 2017, 9:59 PM
• JMinor moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the ios-app-v5.7.1-Corgi-On-Nothing board.Oct 30 2017, 10:33 PM
• JMinor moved this task from Needs Acceptance Criteria to Ready for Development on the ios-app-v5.7.1-Corgi-On-Nothing board.Oct 31 2017, 5:20 PM
JoeWalsh moved this task from Ready for Development to Doing on the ios-app-v5.7.1-Corgi-On-Nothing board.Oct 31 2017, 7:11 PM
JoeWalsh added a comment.Oct 31 2017, 8:35 PM

The issue I'm seeing with places is that when there's a device language/wiki language mismatch, the cells always respect the device language. For example, the cells are RTL for Hebrew Wikipedia on a Hebrew device, but LTR for Hebrew Wikipedia on an English device.

I tried setting the cells' semanticContentAttribute but the problem persisted. Might be a more involved workaround.

• JMinor edited projects, added iOS-app-v5.7.4-Dachshund-On-An-Elk; removed ios-app-v5.7.1-Corgi-On-Nothing, iOS-app-v5.7.0-Corgi-On-A-Surfboard.Oct 31 2017, 9:06 PM
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 6 2017, 10:21 PM
• JMinor removed a project: iOS-app-v5.7.4-Dachshund-On-An-Elk.Nov 16 2017, 8:20 PM
LGoto closed this task as Resolved.Mar 26 2019, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL