Page MenuHomePhabricator
Create Task
Maniphest T177437

Update Echo and Run Maintenance Script
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

This is to deploy the latest version of Echo and run the maintenance script maintenance/updatePerUserBlacklist.php which includes T173475

In T173475#3658336, @Niharika wrote:

Ah, I imagined you'd SWAT this. The train left before your change was merged this week so you should SWAT it and ask the deployer to run it for you. Otherwise this change won't be live on wikis until Thursday next week.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
updatePerUserBlacklist wfWaitForSlaves()mediawiki/extensions/Echomaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

dbarratt created this task.Oct 4 2017, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2017, 7:18 PM
dbarratt added a parent task: T173475: Echo Notification Mute (Block List) can be bypassed by changing username.Oct 4 2017, 7:19 PM
• TBolliger awarded a token.Oct 4 2017, 7:27 PM
• TBolliger subscribed.
dbarratt set the point value for this task to 0.5.Oct 4 2017, 8:11 PM
dbarratt updated the task description. (Show Details)Oct 4 2017, 8:15 PM
dbarratt renamed this task from Deploy Echo Notification Mute (Block List) can be bypassed by changing username to Update Echo and Run Maintenance Script.Oct 5 2017, 6:47 AM
Liuxinyu970226 subscribed.Oct 5 2017, 11:49 AM
dbarratt moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 6) board.Oct 5 2017, 1:01 PM
dbarratt updated the task description. (Show Details)Oct 5 2017, 5:27 PM
dbarratt updated the task description. (Show Details)
dbarratt added a comment.Oct 9 2017, 7:33 PM

The deploy failed (again)

P6096 (An Untitled Masterwork)
1$ mwscript extensions/Echo/maintenance/updatePerUserBlacklist.php --wiki=zhwiki
2Updating Echo Notification Blacklist...
3Updated 0 Users
4PHP Notice: Undefined variable: dbFactory in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
5Notice: Undefined variable: dbFactory in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
6PHP Fatal error: Call to a member function waitForSlaves() on null in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
7Fatal error: Call to a member function waitForSlaves() on null in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
8

dbarratt closed this task as Resolved.Oct 9 2017, 7:56 PM
dbarratt moved this task from In progress to Done on the Anti-Harassment-Team (AHT Sprint 6) board.
dbarratt added a subscriber: hashar.

@hashar is a boss man and fixed the bug and ran the script. This is done!

hashar mentioned this in T173475: Echo Notification Mute (Block List) can be bypassed by changing username.Oct 9 2017, 8:08 PM
gerritbot subscribed.Oct 9 2017, 8:09 PM

Change 383183 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Echo@master] updatePerUserBlacklist wfWaitForSlaves()

https://gerrit.wikimedia.org/r/383183

gerritbot added a project: Patch-For-Review.Oct 9 2017, 8:09 PM
hashar added a comment.Oct 9 2017, 8:10 PM
In T173475#3670451, @hashar wrote:

The updatePerUserBlacklist script required a live hack. I did a commit for the wmf branch but that needs to be ported to the master branch https://gerrit.wikimedia.org/r/383182 updatePerUserBlacklist wfWaitForSlaves()

https://gerrit.wikimedia.org/r/#/c/383183/ is the patch proposed for master :)

Aklapper added a project: Notifications (Echo).Oct 9 2017, 9:38 PM

General reminder: Please add codebase projects like Notifications (Echo) so such tasks can be found when searching for tasks in that codebase project. Thanks.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 9 2017, 9:38 PM
Liuxinyu970226 unsubscribed.Oct 10 2017, 3:03 PM
gerritbot added a comment.Oct 10 2017, 6:51 PM

Change 383183 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] updatePerUserBlacklist wfWaitForSlaves()

https://gerrit.wikimedia.org/r/383183

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 10 2017, 7:00 PM
Catrope mentioned this in T177825: No on-site Notifications received for certain type of actions.Oct 14 2017, 10:48 PM
Catrope subscribed.

This script inserted zeroes (the user ID zero, suggesting a CU lookup failure) into the blacklists of a few thousand users, and possibly broke all notifications for them. See T177825#3685628.

• TBolliger mentioned this in T216185: Analyze use of mute preferences.Mar 6 2019, 6:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits