Page MenuHomePhabricator
Create Task
Maniphest T177446

Broken edit summary preview on mobile VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Displays an apparent message name, "parentheses", instead of the actual edit summary.

Firefox 55.0.2 on Android

20171004_182250.png (1×1 px, 153 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditorwmf/1.31.0-wmf.2+1 -1Move 'parentheses' message to MWSaveDialog's modules
mediawiki/extensions/VisualEditormaster+1 -1Move 'parentheses' message to MWSaveDialog's modules
Customize query in gerrit

Event Timeline

• Mattflaschen-WMF created this task.Oct 4 2017, 10:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2017, 10:44 PM
• Mattflaschen-WMF updated the task description. (Show Details)Oct 4 2017, 10:46 PM
gerritbot added a subscriber: gerritbot.Oct 5 2017, 12:14 PM

Change 382428 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Move 'parentheses' message to MWSaveDialog's modules

https://gerrit.wikimedia.org/r/382428

gerritbot added a project: Patch-For-Review.Oct 5 2017, 12:14 PM
Deskana assigned this task to Esanders.Oct 5 2017, 12:45 PM
Deskana triaged this task as High priority.
Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Deskana set the point value for this task to 1.
gerritbot added a comment.Oct 5 2017, 3:51 PM

Change 382428 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Move 'parentheses' message to MWSaveDialog's modules

https://gerrit.wikimedia.org/r/382428

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 5 2017, 4:00 PM
Deskana added a subscriber: Deskana.Oct 5 2017, 4:16 PM

Let's get this SWAT deployed. I don't want a bug like this sitting around for a week.

gerritbot added a comment.Oct 5 2017, 5:10 PM

Change 382490 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.2] Move 'parentheses' message to MWSaveDialog's modules

https://gerrit.wikimedia.org/r/382490

gerritbot added a comment.Oct 5 2017, 6:48 PM

Change 382490 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.2] Move 'parentheses' message to MWSaveDialog's modules

https://gerrit.wikimedia.org/r/382490

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 5 2017, 7:01 PM
Stashbot added a subscriber: Stashbot.Oct 5 2017, 7:49 PM

Mentioned in SAL (#wikimedia-operations) [2017-10-05T19:49:28Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.2/extensions/VisualEditor/extension.json: SWAT: [[gerrit:382490|Move 'parentheses' message to MWSaveDialog's modules]] T177446 (duration: 00m 50s)

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki, VisualEditor-MediaWiki-Mobile; removed Patch-For-Review.Oct 5 2017, 7:51 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Verified fixed in production, now it's back-ported.

Jdforrester-WMF closed this task as Resolved.Oct 5 2017, 7:51 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 5 2017, 7:51 PM
Deskana added a comment.Oct 5 2017, 9:47 PM

Thanks!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL