Page MenuHomePhabricator

When selecting a page to translate don't provide an option to create a new page
Closed, ResolvedPublic

Description

The dialog to create a new translation (T111094) let's user select a page that exists in the selected language in order to be translated. It is important that the page does exist in order for the user to translate it.
However, currently when searching for a non existing page, an option is provided to create such page:

This option does not make sense, and should not be provided.
We can show a message similar to the empty state we considered in T111094#3645856, to communicate that there are no pages for that search. Surfacing the search used and the language in which the user is searching as part of the message can help the user to identify the problem if any (e.g., a typo or searching in the wrong language):

Details

Related Gerrit Patches:
mediawiki/extensions/ContentTranslation : masterChange empty result states
mediawiki/core : masterAdd option to hide missing pages while searching
mediawiki/core : masterAdd option to hide missing pages while searching

Event Timeline

Arrbee removed a project: Epic.Oct 6 2017, 7:16 AM

Change 383174 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Add option to hide missing pages while searching

https://gerrit.wikimedia.org/r/383174

Change 383176 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Change empty result states

https://gerrit.wikimedia.org/r/383176

Petar.petkovic moved this task from Backlog to For Review on the User-Petar.petkovic board.

Change 383413 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Add option to hide missing pages while searching

https://gerrit.wikimedia.org/r/383413

Change 383413 abandoned by Petar.petkovic:
Add option to hide missing pages while searching

Reason:
Mistake

https://gerrit.wikimedia.org/r/383413

Change 383174 merged by jenkins-bot:
[mediawiki/core@master] Add option to hide missing pages while searching

https://gerrit.wikimedia.org/r/383174

Change 383176 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Change empty result states

https://gerrit.wikimedia.org/r/383176

Checked in cx-testing.
If a page does not exist, the following warning will be displayed to a user:

Etonkovidova closed this task as Resolved.Nov 9 2017, 7:30 PM
Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.