Fix Uncaught Error: Widget not found
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Oct 5 2017, 1:07 PM

Description

When I click reply on a thread, on error console I see:

Uncaught Error: Widget not found

at Object.OO.ui.Element.static.unsafeInfuse (Element.js:144)
at Object.OO.ui.Element.static.infuse (Element.js:104)
at Object.OO.ui.infuse (core.js:326)
at HTMLDocument.<anonymous> (mediawiki.action.edit.js?29a7f:23)
at mightThrow (load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1uclx17:3583)
at process (load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1uclx17:3651)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+16 -11	edit: Fix assumption #wpSummary is always there

Customize query in gerrit

Related Objects

Mentioned Here: T57463: LiquidThreads: LQT preview should not rely on mediawiki.action.edit.preview
T111088: Convert EditPage.php to use OOUI rather than MW UI

Event Timeline

Nikerabbit created this task.Oct 5 2017, 1:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2017, 1:07 PM

Nikerabbit added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Oct 5 2017, 1:08 PM

It looks like the same kind of issue as T57463, where LiquidThreads loads the core 'mediawiki.action.edit' module on its pages. The module was changed a bit recently to match the update of edit form to OOUI (T111088) and presumably those changes were not reflected in LiquidThreads. It's LiquidThreads responsibility to keep its markup compatible with the core module. Or just stop using it – to be honest I don't see what it's even loaded for, as the module doesn't do very much.

Nikerabbit added a project: User-Nikerabbit.Oct 10 2017, 8:12 AM

confirmed

• Phabricator_maintenance added a project: affects-translatewiki.net.Sep 26 2019, 1:53 PM

• Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM

Still happening, FWIW.

Change 575551 had a related patch set uploaded (by Bartosz Dziewoński; owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] edit: Fix assumption #wpSummary is always there

https://gerrit.wikimedia.org/r/575551

gerritbot added a project: Patch-For-Review.Feb 28 2020, 6:15 PM

Change 575551 merged by jenkins-bot:
[mediawiki/core@master] edit: Fix assumption #wpSummary is always there

https://gerrit.wikimedia.org/r/575551

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2020, 7:11 PM

matmarex closed this task as Resolved.Feb 28 2020, 8:15 PM

matmarex assigned this task to thiemowmde.