|mediawiki/extensions/CodeMirror : master||Enable spellchecking on Firefox|
- Mentioned In
- T188607: Syntax highlighting disables middle button copy/paste in Firefox
T188757: Syntax highlighting with old editor breaks Firefox's spell checker
- Mentioned Here
- T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror
T184467: CodeMirror in 2017 Wikitext Editor shows overlapping text in Firefox
I cannot reproduce this on Firefox 58.0.2 (64-bit) on OSX 10.13.3 while testing on the 2010 wikitext editor on https://en.wikipedia.org/wiki/List_of_2014_professional_women%27s_cycling_teams?action=edit&veswitched=1&oldid=755859946 or any other page
From the other ticket:
MusikAnimal added a subscriber: MusikAnimal.Edited · Fri, Mar 2, 9:43 AM
I believe spell checking on Firefox / non-Mac was disabled with https://gerrit.wikimedia.org/r/#/c/382023/ because it causes problems with access keys. More at T95104
Bencemac added a comment.Fri, Mar 2, 9:59 AM
@MusikAnimal Thanks, you are right! Then we have to wait till they fix it.
Aklapper added a comment.Fri, Mar 2, 10:15 AM
Is this the same as T177509? If so, could you mark T177509 as a duplicate (via Edit Related Tasks... → Close As Duplicate)?
Niharika added a subscriber: Niharika.Fri, Mar 2, 10:16 AM
I believe this will be fixed if we fix T184467: CodeMirror in 2017 Wikitext Editor shows overlapping text in Firefox or more specifically, T184467#3958893.
I still can't get reproduce this defect on my Macbook running OSX 10.13.3 High Sierra. I tried every combination of browser language, keyboard language, input language, and mediawiki language preference on Hungarian and English.
I'm not saying it's an invalid bug on your machine — there must be something else at play. Are you on a Windows machine?
Oooh, you're right. I remembered we disabled it but I didn't remember that it was supposed to be enabled for Mac users.
I'm gonna revert that change (this was the fix we were initially going to deploy for T184467) and we can see if there are still problems with editing in Firefox.
If it turns out that it creates problems then we can deploy it again.
The patch is at https://gerrit.wikimedia.org/r/#/c/421349/
Fomafix raised a valid concern about https://github.com/codemirror/CodeMirror/issues/5253 still being an issue. I'm unable to test it, being on a Mac. Can someone else confirm if this still happens with the latest Firefox version?
It can be tested at http://commtech.wmflabs.org/w/index.php?title=Sample_page&action=edit
This means, that disabling of the spellchecking in Firefox is not needed anymore. https://gerrit.wikimedia.org/r/421349 removes the disabling of the spellchecking and can now merged. Maybe a version check of the exact Firefox version should remain to prevent that older Firefox versions accidentally insert accesskey characters into the content when the accesskey is used.