Page MenuHomePhabricator

Update messaging to clarify sync behavior is per account level
Closed, ResolvedPublic3 Estimated Story Points

Description

Problem

Per T167311, reading lists are completely removed from the server when sync is disabled; but it is currently ambiguously worded in Settings whether turning off sync only disables it on one device or whether it turns it off across the entire account (the correct behavior).

Proposed solution

Part (i) Update the sync setting text strings to clarify this account setting behavior.

CurrentProposed
TitleSync reading listsSync reading lists for this account
DescriptionAllow Wikimedia to sync your reading lists when you log inAllow Wikimedia to sync reading lists to your Wikipedia account <username if logged in>
Warning dialog when turning off sync - titlenoneRemove synced reading lists from your account <username if logged in>?
Warning dialog when turning off sync - textThis will delete any previously synced reading lists from remote storage. Proceed?This will completely delete all previously synced reading lists from remote storage. Remove all synced lists from your account <username if logged in>?

NOTE: This setting should only be enabled for logged in users. See T183476

Part (ii) Add a toast message across all other logged in sessions advising when sync has been disabled on one device.
When a user turns OFF syncing on one of their devices, the next time they open another device where they are logged in, there should be a notification advising that sync has been turned off for the account.
Proposed message - dialog:

TitleReading list sync turned off
MessageReading list sync is off for your account, and saved articles on your logged in devices are no longer being backed up. Turn on reading list sync in Settings.
CTA 1OK dismisses dialog
CTA 2SETTINGS goes to the app settings

QA steps

Scenario: User logged in to multiple devices disables syncing from *one* device

Pre-requisite: User is logged in on two devices with sync active on both

  1. On device #1, go to settings and disable syncing
  2. Open device #2.
  3. User creates a new reading list "Delta" with some articles on device #2.
  4. Go to Settings and re-enable sync on device #2
  5. Return to device #1 where sync should now be active again

Expected behavior:

  • In step 2, the message that sync is no longer active is shown to the user upon opening the app.

-In step 2, device #2 should still show all the saved reading lists since it is still locally stored, but the server will have deleted all reading list items.
-In step 4, device #1 should sync with the same reading list content as what is on device #2, including the new "Delta" list

Event Timeline

NHarateh_WMF removed the point value for this task.
RHo renamed this task from Define sync behavior as being either per account or per device to Define sync behavior in the app as per account level.Oct 10 2017, 6:14 PM
RHo updated the task description. (Show Details)

Testing on Wikipedia app 2.6.206-alpha-2017-11-20 with Device 1: ZTE Maven (Z812) and Device 2: Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1).
[The Galaxy Express 3 did not have a Sync disabling Setting so I had to make the ZTE the Device 1.]
This is fixed as changing Sync settings on ZTE, creating a new reading list on Galaxy, nevertheless Sync was active and the new Delta reading list showed on both devices. Screencaps shown below.

RHo renamed this task from Define sync behavior in the app as per account level to Update messaging to clarify sync behavior is per account level.Nov 29 2017, 6:07 PM

Change 399468 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Update messaging to clarify sync behavior is per account level

https://gerrit.wikimedia.org/r/399468

@RHo
For the proposed message from Part (ii), seems like the current patch can not be able to sync user options (the setting of sync enable/disable).

Also the syncing behavior looks weird now. @Dbrant

Wipe app data -> open the app -> login Wikipedia account -> does not trigger the behavior of syncing reading list

Will investigate it

RHo updated the task description. (Show Details)

hey @cooltey - just filed another task T183476 which may rectify weirdness you're seeing. Basically this setting shouldn't be enabled unless a user is logged in.

Thanks @RHo, will move T177516 to waiting/blocked until we finish T183476

Change 399468 merged by jenkins-bot:
[apps/android/wikipedia@master] Sync Reading Lists behavior dialogs

https://gerrit.wikimedia.org/r/399468