Submitted a patch: gerrit change

Change 382572 had a related patch set uploaded (by Jforrester; owner: 20after4):
[mediawiki/extensions/WikimediaMaintenance@master] In addWiki, add "IF NOT EXISTS" to CREATE DATABASE statement.

https://gerrit.wikimedia.org/r/382572

Note that there must be more instances missing the IF NOT EXISTS, my patch just fixes one 'create database' statement.

What's calling addWiki though?

In T177537#3662368, @mmodell wrote:

Note that there must be more instances missing the IF NOT EXISTS, my patch just fixes one 'create database' statement.

They're already there for external storage and the echo cluster

Oh, this is just to avoid causing more T177535 issues in future?

the IF NOT EXISTS plays a lot more nicely with replication if things go wrong

Don't think it's anything to do with T177535 though

Change 382572 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] In addWiki, add "IF NOT EXISTS" to CREATE DATABASE statement.

https://gerrit.wikimedia.org/r/382572

I was wrong- while the IF EXIST is still needed, it was not the cause of replication breakage (at least not this time), apparently amwikimedia was created on s7 first, and then on s3, which lead to dbstores (using multisource) to complain about some duplicates. All of amwikimedia on s7 should have been deleted before continuing the deployment. See https://phabricator.wikimedia.org/T176043#3690781 and following.

I think the patch is still needed, and it did work only because we do not have all data that we should on all hosts.

In T177537#3690936, @jcrespo wrote:

I think the patch is still needed, and it did work only because we do not have all data that we should on all hosts.

It's certainly not going to cause any harm staying around now it has been merged

Oh, was already merged? Then this can be closed?