Page MenuHomePhabricator
Create Task
Maniphest T177657

[BUG] No image on the "Because you read" or "Continue reading" card in certain articles
Closed, ResolvedPublic
Actions

Description

This is a minor bug, not sure it is an App side bug or an API side bug.

Steps to reproduce

  1. Search article: Yankee Stadium (1923)
  2. In the article page, click on "Change Language", and search "Traditional Chinese" (繁體)
  3. Read this page at least for 1 minute, and back to the Feed page, and then refresh the Feed page.
  4. Make sure you can see the "洋基體育場 (1923年)" on either the "Continue Reading" or "Because you read"

Expected

Title with an Image (the example shows below is a Simplified Chinese version of Yankee Stadium (1923)

no_image2.png (1×682 px, 430 KB)

Actual

No image

no_image.png (1×693 px, 400 KB)

Details

SubjectRepoBranchLines +/-
Properly deserialize MwQueryResult, with postprocessing!apps/android/wikipediamaster+146 -59
Don't emit a BecauseYouRead card when no suggestions are available.apps/android/wikipediamaster+11 -8
Customize query in gerrit

Event Timeline

cooltey created this task.Oct 6 2017, 7:41 PM
Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptOct 6 2017, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• NHarateh_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada); removed Wikipedia-Android-App-Backlog.Oct 10 2017, 4:23 PM
RHo subscribed.Oct 10 2017, 4:23 PM

We may also need to fix a possibly related bug that the suggested related articles under 'Because you read' are also not showing

Dbrant claimed this task.Oct 10 2017, 6:56 PM
Dbrant moved this task from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.
gerritbot subscribed.Oct 10 2017, 11:01 PM

Change 383482 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Bug: T177657 Change-Id: If99f35977700261d4da84d1a05d585d8c57c8c04

https://gerrit.wikimedia.org/r/383482

gerritbot added a project: Patch-For-Review.Oct 10 2017, 11:01 PM

Change 383483 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Properly deserialize MwQueryResult, with postprocessing!

https://gerrit.wikimedia.org/r/383483

gerritbot added a comment.Oct 10 2017, 11:03 PM

Change 383482 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Don't emit a BecauseYouRead card when no suggestions are available.

https://gerrit.wikimedia.org/r/383482

gerritbot added a comment.Oct 11 2017, 3:11 PM

Change 383482 merged by jenkins-bot:
[apps/android/wikipedia@master] Don't emit a BecauseYouRead card when no suggestions are available.

https://gerrit.wikimedia.org/r/383482

gerritbot added a comment.Oct 11 2017, 5:49 PM

Change 383483 merged by jenkins-bot:
[apps/android/wikipedia@master] Properly deserialize MwQueryResult, with postprocessing!

https://gerrit.wikimedia.org/r/383483

• Mholloway moved this task from Doing to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 11 2017, 10:39 PM
Nicholas.tsg subscribed.Oct 23 2017, 10:36 PM

Testing on Android 5.1 ZTE Maven (Z812) and Wikipedia app 2.6.203-alpha-2017-10-23. I think this has improved as, even though "Because you read" doesn't say "洋基體育場 (1923年)" exactly, it is in "Traditional Chinese" (繁體) and includes the lead image. There is no "Continue Reading" section, "Today on Wikipedia" appears above, this might not matter but I'll leave it up to everyone here to decide.

T177657.png (854×480 px, 139 KB)

Dbrant moved this task from QA Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 30 2017, 3:51 PM
Dbrant closed this task as Resolved.Oct 30 2017, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL