Page MenuHomePhabricator
Create Task
Maniphest T177659

Page icons in Special:Search completion suggester don't differentiate between page types
Closed, ResolvedPublic
Actions

Description

h_1507318239_9213027_915d8b13b4.jpeg (432×698 px, 53 KB)

When searching on Special:Search (not the navigation search field) the autocompletion list shows an icon next to each entry. These should show a different icon for disambiguation, existing, not found, etc. They appear to only be showing a single icon for all page status/types.

I think this was introduced with MediaWiki 1.31/wmf.2

https://gerrit.wikimedia.org/r/#/c/381451/

Details

SubjectRepoBranchLines +/-
SearchInputWidget: Don't show imagesmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

CKoerner_WMF created this task.Oct 6 2017, 7:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2017, 7:56 PM
Quiddity subscribed.Oct 6 2017, 7:57 PM
debt triaged this task as High priority.Oct 6 2017, 8:00 PM
debt added projects: Discovery-ARCHIVED, Discovery-Search (Current work).
gerritbot subscribed.Oct 6 2017, 8:01 PM

Change 382774 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] SearchInputWidget: Don't show images

https://gerrit.wikimedia.org/r/382774

gerritbot added a project: Patch-For-Review.Oct 6 2017, 8:01 PM
Jdforrester-WMF edited projects, added UI-Standardization; removed OOUI.Oct 6 2017, 8:05 PM
Jdforrester-WMF subscribed.

Not part of OOjs UI, this is a MediaWiki widget.

Esanders subscribed.Oct 7 2017, 9:19 PM

If images aren't working with the default configuration, we should change the default to be false.

Esanders added a comment.Oct 7 2017, 9:47 PM

So crazily the opensearch API only returns descriptions and images in XML format, but not JSON (see examples: https://www.mediawiki.org/wiki/API:Opensearch ). And the images are always 50px thumbs, not configurable.

gerritbot added a comment.Oct 8 2017, 1:40 AM

Change 382774 merged by jenkins-bot:
[mediawiki/core@master] SearchInputWidget: Don't show images

https://gerrit.wikimedia.org/r/382774

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 8 2017, 2:00 AM
dcausse moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.Oct 10 2017, 9:04 AM
debt subscribed.Oct 10 2017, 4:56 PM

Thanks for the fast patch, @Jdforrester-WMF and investigation @Esanders :)

debt closed this task as Resolved.Oct 13 2017, 3:45 PM
debt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL