Page MenuHomePhabricator

Echo's update keys are not guaranteed to be stable
Open, Needs TriagePublic

Description

(21:16) root@localhost:[wiki]> select * from updatelog where ul_key like 'echo%';
+------------------------------------------------------------------------------------------------------------+----------+
| ul_key                                                                                                     | ul_value |
+------------------------------------------------------------------------------------------------------------+----------+
| echo_event-event_agent_ip-/vagrant/mediawiki/extensions/Echo/db_patches/patch-event_agent_ip-size.sql      | NULL     |
| echo_event-event_extra-/vagrant/mediawiki/extensions/Echo/db_patches/patch-event_extra-size.sql            | NULL     |
| echo_event-event_variant-/vagrant/mediawiki/extensions/Echo/db_patches/patch-event_variant_nullability.sql | NULL     |
+------------------------------------------------------------------------------------------------------------+----------+

Full paths in update keys mean that when the wiki gets moved around or Echo gets refactored, some updates will be run for the second time.

Related Objects

Event Timeline

MaxSem created this task.Oct 6 2017, 9:19 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 6 2017, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MaxSem updated the task description. (Show Details)Oct 6 2017, 9:19 PM

Is this specific to Echo, or do all extensions have this issue? Is Echo using anything weird here, or is it just using standard things?

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 14 2018, 12:51 PM