Get Equivset Test Coverage to 100%
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	dbarratt
	Oct 6 2017, 9:22 PM

Description

We should up the Equivset test coverage to 100%

Details

	Subject	Repo	Branch	Lines +/-
	Increase Test Coverage to 100%	mediawiki/libs/Equivset	master	+600 -139

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• TBolliger	T166816 Epic ⚡️ : Accuracy improvements to anti-spoof tools across multiple pertinent tools
Resolved	dbarratt	T174195 More extensive unit testing for AntiSpoof
Resolved	dbarratt	T178704 Enforce that Equivset Test Coverage Remains at 100%
Resolved	dbarratt	T177667 Get Equivset Test Coverage to 100%
Resolved	dbarratt	T174197 Split off AntiSpoof equivset generation and string normalization into its own library

Event Timeline

dbarratt created this task.Oct 6 2017, 9:22 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 6 2017, 9:22 PM

dbarratt edited projects, added Anti-Harassment; removed Anti-Harassment (AHT Sprint 6).Oct 6 2017, 9:23 PM

dbarratt set the point value for this task to 3.Oct 10 2017, 10:51 PM

Change 383498 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/libs/Equivset@master] Increase Test Coverage to 100%

https://gerrit.wikimedia.org/r/383498

gerritbot added a project: Patch-For-Review.Oct 11 2017, 3:07 AM

@Legoktm is there anyway to enforce (with Jenkins) that we maintain 100% code coverage?

bd808 removed a project: Librarization.Oct 11 2017, 3:45 AM

• TBolliger moved this task from Untriaged to Cards ready for development on the Anti-Harassment board.Oct 11 2017, 2:52 PM

dmaza moved this task from Cards ready for development to AHT Sprint 7 on the Anti-Harassment board.Oct 11 2017, 6:38 PM

dmaza edited projects, added Anti-Harassment (AHT Sprint 7); removed Anti-Harassment.

dbarratt moved this task from Ready to Code Review on the Anti-Harassment (AHT Sprint 7) board.Oct 11 2017, 7:00 PM

Whatever we put into the "composer test" command gets run by jenkins. So if there's a way to make phpunit or something else complain when coverage isn't 100% that would be the recommended way.

In T177667#3678161, @Legoktm wrote:

Whatever we put into the "composer test" command gets run by jenkins. So if there's a way to make phpunit or something else complain when coverage isn't 100% that would be the recommended way.

Fantastic. Done!

@Legoktm uhh... we need Xdebug in Jenkins. :(

15:33:49 Warning: The Xdebug extension is not loaded
15:33:49 No code coverage will be generated.

Following up on the IRC ping.

xdebug is installed via Debian packages which should enable it by default an ini file. We have a task to stop loading xdebug since that slow down PHP T175028. To generate coverage we would thus invoke php with: php -d extension=xdebug.so.

AFAIK xdebug is still enabled. If it is not that is a bug I guess. Do you have a Gerrit change and job name that shows the issue?

hashar added a project: Continuous-Integration-Config.Oct 18 2017, 7:34 PM