Page MenuHomePhabricator

Slightly reduce label `margin-top` without negatively impacting proximity principle
Closed, ResolvedPublic

Description

As of v0.23.3, WikimediaUI theme's rules set margin-top of fieldLayouts to 15px on consecutive and inline ones and 21px on others.
It is possible to

  • not negatively impacting visual proximity principle,
  • stay harmonious with the label header to widget distance (currently 4px),
  • not negatively impacting touch area minimum sizes (distances) and
  • use a multiplier of 8px, chosen as our base value for vertical rhythm
BeforeAfter

Details

Event Timeline

Volker_E triaged this task as High priority.Oct 6 2017, 10:56 PM
Volker_E created this task.
Volker_E updated the task description. (Show Details)Oct 6 2017, 11:11 PM

Change 382890 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Reduce FieldLayout margin-top slightly

https://gerrit.wikimedia.org/r/382890

Volker_E closed this task as Resolved.Oct 7 2017, 12:43 AM
Volker_E moved this task from Backlog to OOjs-UI-0.23.4 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.23.4); removed OOUI.
Volker_E removed a project: Patch-For-Review.

Change 382890 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Reduce FieldLayout margin-top slightly

https://gerrit.wikimedia.org/r/382890

Restricted Application added a project: UI-Standardization. · View Herald TranscriptOct 7 2017, 1:09 AM