Page MenuHomePhabricator
Create Task
Maniphest T177683

WikimediaUI theme: Reduce whitespace of CheckboxMultiselectInputWidget and RadioSelectInputWidget in flatlists
Closed, ResolvedPublic
Actions

Description

As of v0.23.3, the inner structure of CheckboxMultiselectInputWidget and RadioSelectInputWidget in flatlists results in unwanted whitespace:

.oo-ui-checkboxMultiselectInputWidget .oo-ui-fieldLayout .oo-ui-fieldLayout-body {
    padding: 0.3125em 0;
}
BeforeAfter
T177683 flatlist checkbox options _before - Blocked users - Wikipedia 2017-10-06.png (458×1 px, 53 KB)
highlights: aquamarine padding, coral content height
image.png (267×738 px, 25 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+2 -0HTMLForm OOUI Flatlist: Reduce `margin` slightly
oojs/uimaster+6 -14WikimediaUI theme: Reduce Checkbox*- & RadioSelectInputWidget vertical space
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Oct 7 2017, 4:03 AM
Volker_E updated the task description. (Show Details)Oct 7 2017, 4:09 AM
Volker_E renamed this task from WikimediaUI theme: Reduce whitespace of checkboxes and radios in flatlists to WikimediaUI theme: Reduce whitespace of CheckboxMultiselectInputWidget and RadioSelectInputWidget in flatlists.Oct 7 2017, 4:16 AM
Volker_E updated the task description. (Show Details)
gerritbot added a subscriber: gerritbot.Oct 7 2017, 4:34 AM

Change 382935 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Reduce Checkbox*- & RadioSelectInputWidget vertical space

https://gerrit.wikimedia.org/r/382935

gerritbot added a project: Patch-For-Review.Oct 7 2017, 4:34 AM
gerritbot added a comment.Oct 10 2017, 10:43 PM

Change 382935 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Reduce Checkbox*- & RadioSelectInputWidget vertical space

https://gerrit.wikimedia.org/r/382935

Volker_E edited projects, added OOUI; removed Patch-For-Review.Nov 1 2017, 11:30 PM
Volker_E removed a subscriber: gerritbot.
Volker_E raised the priority of this task from High to Needs Triage.Aug 22 2018, 12:48 AM
Volker_E moved this task from Backlog to Next-up on the OOUI board.
Volker_E moved this task from Next-up to Backlog on the OOUI board.Oct 25 2018, 3:03 AM
gerritbot added a comment.Dec 18 2018, 6:21 AM

Change 327039 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] HTMLForm OOUI Flatlist: Reduce margin slightly

https://gerrit.wikimedia.org/r/327039

gerritbot added a project: Patch-For-Review.Dec 18 2018, 6:21 AM
gerritbot added a comment.Dec 18 2018, 1:16 PM

Change 327039 merged by jenkins-bot:
[mediawiki/core@master] HTMLForm OOUI Flatlist: Reduce margin slightly

https://gerrit.wikimedia.org/r/327039

matmarex closed this task as Resolved.Dec 18 2018, 1:36 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 18 2018, 2:01 PM
Volker_E removed a project: Patch-For-Review.Dec 18 2018, 5:40 PM
Volker_E updated the task description. (Show Details)Dec 18 2018, 8:56 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL