Align all colors to overhauled WikimediaUI color palette.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Volker_E | T148708 Replace abandoned colors in current WMF/Wikimedia products with WikimediaUI palette colors (tracking) | |||
| Resolved | Volker_E | T177723 Align Notifications/Echo to WikimediaUI color palette |
Event Timeline
Comment Actions
Change 383016 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Replacing fallback color for code hygiene
Comment Actions
Change 383021 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Align popup message color to toast message in MinervaNeue
Comment Actions
Change 383036 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Fix CrossWiki-/BundleGroup layout
Comment Actions
The footer buttons are not clearly distinct from the items. Ideas?
@Pginer-WMF Replacing NotificationItemWidget's background-color from currently #f1f1f1 with #f8f9fa would result in a somewhat dissatisfying:
The footer buttons are not clearly distinct from the items. Ideas?
Comment Actions
Change 383037 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Replace subtle greys with WikimediaUI color palette ones
Comment Actions
Before 383036 After
The before/after comparison shows another change apart from color. When expanding a bundle, part of the parent bundle is shown after its contents to emphasise that those are shown inside. This white stripe seems to be gone with the change.
Comment Actions
Change 383037 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replace subtle greys with WikimediaUI color palette ones
Comment Actions
Change 383021 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Align popup message color to toast message in MinervaNeue
Comment Actions
Change 383036 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix CrossWiki-/BundleGroup layout
Comment Actions
Checked in betalabs and wmf.6 - the white stripe is present for bundled notifications. However, there is a slight visual difference (quite minor) between cross-wiki bundled notifications and the same wiki notifications bundle.
cross-wiki bundle
the same wiki bundled notifications
If @Pginer-WMF regarding the above - should it be adjusted?
Comment Actions
It would be nice to be the same, but I'm more concerned about the padding around the bundled elements. There the top padding seems much smaller than the padding on the other sides. I marked top and bottom paddings in red and blue to illustrate the issue:
I think the space was better balanced before, so I'm not sure what has introduced this regression.
Comment Actions
I think it is not as clear that those elements are sub-elements while there is too much going (borders, backgrounds, box-shadows, double margins) on to visualize that parent>child idea.
Comment Actions
Change 390299 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Echo@master] Equal CrossWiki/BundleNotificationItemWidget group's padding
Comment Actions
Change 390299 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Equal CrossWiki/BundleNotificationItemWidget group's padding
Comment Actions
The remaining pieces here are a fallback color handled in https://gerrit.wikimedia.org/r/#/c/383016/ and the question about read notifications handled in T78594.
Comment Actions
Change 383016 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replacing fallback color for code hygiene