Page MenuHomePhabricator

Structured discussions email notification about a change on a page description: change "view page" to "view changes" as the primary link
Open, Needs TriagePublic

Description


When you receive a notification by email about a change on a SD board description, the most obvious link to click on (the blue button) redirects you to the page like it is now, instead of redirecting you to the diff you plan to look at.

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 9 2017, 9:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Pginer-WMF, an idea on how we can change the design to 1/ keep the consistency between the email notification and the notification on-site and 2/ help to solve that case? Thanks!

Catrope added a subscriber: Catrope.Dec 5 2017, 8:38 PM

Some additional information/context: the big blue button is the primary action, i.e. it corresponds to the URL that you go to when clicking the notification in the web view. The other links next to the blue button are secondary links and correspond to the secondary actions that are displayed at the bottom of the notification or in the dotdotdot menu in the web view. Changing what the blue button in the email points to also changes what clicking the notification in the web view does. In this case I think that's fine: most other notifications about things being edited lead to the edit as the primary link.

I think the design for how we display secondary links in notification emails generally could be improved. For one thing, the fact that we don't have the icons in there is bad, because it makes things like the user secondary link very confusing (it's not clear that that's a user name without the user icon in front of it). We also don't have a clear separation between the different secondary links.

Deciding on the primary action requires to prioritise some usecases over others. Linking to the affected content was considered as the primary action for simplicity reasons. It does not require the interpretation effort that current diff view requires. The drawback of this approach is that it is less precise: the user needs to figure out at a glance if the description was vandalised (easy), it was improved (not that easy to detect) or some relevant information may have disappeared (harder to detect). We decided to err on the side of less experienced users (not requirign to be able to navigate the diff system) by default and provide what we considered more advanced tools as secondary actions.

If there were a view where the real content is shown with some indicators on what changed (highlighting what's added), that could be a good destination to direct users to by default. However, the current possible destination seem to be either the final content or a separate two-column wikitext-based diff that seems disconnected from the board it refers to, without any intermediate position.

When you click on the blue button, you have access to the board, and no indication of what has changed. Like you said, it is only easy to detect an obvious vandalism. Other cases are not detectable: you may miss a broken link or an insignifiant change.

For a Structured discussion board, the easier way to handle a change is to access the diff. From a board, it is very difficult to understand which edit is a diff between the previous description and the current one. Plus you have a clear context when you access the diff: you know where you are and where to go to have more information. (Gosh, I'm advocating to have wikitext displayed first. o_O)

There is several problems shown by that simple request:

  • the lack of icons in the message (that's common to all notification emails -> T182204)
  • the lack of padding between the different links
  • the lack of visual diff on the board itself (woah!) or, at least, in the diff.

Would it be possible to increase the visibility of the secondary link (here the link to the diff)?

There is several problems shown by that simple request:

  • the lack of icons in the message (that's common to all notification emails -> T182204)
  • the lack of padding between the different links
  • the lack of visual diff on the board itself (woah!) or, at least, in the diff.

Would it be possible to increase the visibility of the secondary link (here the link to the diff)?

Regardless of which is the primary action, I think the changes about styling the email closer to the way we present notifications seem a good idea, for general consistency but also to avoid those actions to be missed. I'd recommend to have a separate ticket focused on that, or adjust the title and description of the current one if that is the scope we want for it.

SBisson added a subscriber: SBisson.Feb 1 2018, 5:41 PM

From the discussion above, I gather that

  1. There is a need for visual improvements on the notification emails. Some of it is already tracked in tickets (see T182204) but it doesn't belong in the current ticket.
  2. There is no consensus for changing the primary link. This needs to be clarified for this ticket to be actionable.
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 10:59 PM