Page MenuHomePhabricator

Publish Changes button not working some times on hindi wikipedia
Closed, InvalidPublic

Description

This is not happening every time, but many times it does happen. When I edit something and click on publish changes it doesnt do anything. I have attached the screenshots of console for ready reference.

Screenshot (4).png (768×1 px, 221 KB)

Screenshot (5).png (768×1 px, 222 KB)

Screenshot (6).png (768×1 px, 233 KB)

Event Timeline

Deskana changed the task status from Open to Stalled.Oct 10 2017, 9:00 AM
Deskana subscribed.

I can't reproduce this in my sandbox. Please give more detailed reproduction steps.

@Capankajsmilyo: Please manually add debug=true in the URL (see https://www.mediawiki.org/wiki/Help:Locating_broken_scripts for more information, though that is about scripts) so the output in the Developer Tools points to the actual files, and please follow https://www.mediawiki.org/wiki/How_to_report_a_bug as requested to structure your bug reports. Thanks!

@Jayprakash12345: Please do not set the priority field.

@Capankajsmilyo Next time it happens, please open your browser console and tell us what errors are present. That's good information to have anyway, but it's especially important if there are no steps that can consistently reproduce the issue.

Aklapper raised the priority of this task from High to Needs Triage.Oct 11 2017, 12:02 PM

The second line of your output says:
at https://hi.wikipedia.org/w/load.php?debug=true&lang=en&modules=ext.gadget.defaultsummaries&only=scripts&skin=vector

Under https://hi.wikipedia.org/wiki/विशेष:वरीयताएँ#mw-prefsection-gadgets, do you have डिफ़ॉल्ट संपादन सारांश बॉक्स के नीचे अक्सर उपयोग में आनेवाले कुछ नए संपादन सारांशों की सूची जोड़ें। enabled? Does the problem still happen if you disable that gadget?

@Aklapper I did some test. When I enabled डिफ़ॉल्ट संपादन सारांश बॉक्स के नीचे अक्सर उपयोग में आनेवाले कुछ नए संपादन सारांशों की सूची जोड़ें। I need to Click 2-3 times on Public Edit. But when I Disabled It. I need to click only one time for new Public Edit Window.

Alright, I'd guess that someone on Hindi Wikipedia has to fix https://hi.wikipedia.org/wiki/मीडियाविकि:Gadget-defaultsummaries.js which has not been modified since 2014. While the original version of that code has received changes since 2014: https://en.wikipedia.org/w/index.php?title=MediaWIki:Gadget-defaultsummaries.js&action=history

This is on-wiki code, so the community on the wiki is responsible for their code. Hence this problem is not handled in Phabricator and I am closing this task as invalid.

Note: There is no good reason why to copy code and then not maintain that copy of your code and then see your unmaintained copy of code break at some point.
Hindi Wikipedia community please take a look at https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#Keep_gadgets_central - thanks! :)