Hello,
i tried to install QuickGV on windows system. Unfortunetely I encountered some issues.
I digged into the problem and found an issue in QuickGV.body.php
In line 73: $phpcmd = self::findExecutable('php', self::PHP_PATH);
the php.exe should be searched. But the method findExecutable ignores the first parameter on windows systems.
The method always searches for dot.exe.
I changed line 73 to:
$phpcmd = PHP_BINARY;
Kind regards,
Thomas
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Fix for windows system to find php.exe | Gerrit Patch Uploader | mediawiki/extensions/QuickGV | master | +4 -1 |
Thanks for taking a look at the code!
You are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review them quickly and provide feedback. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!
Hello,
i created a patch and uploaded it: https://gerrit.wikimedia.org/r/#/c/383509/
As i am not a PHP developer and also not too deep into this project, there might be better solutions than the suggested.
Thanks!
Thomas
Change 383509 had a related patch set uploaded (by Aklapper; owner: ThomasHof):
[mediawiki/extensions/QuickGV@master] Fix for windows system to find php.exe
Change 383509 merged by jenkins-bot:
[mediawiki/extensions/QuickGV@master] Fix for windows system to find php.exe
Related patch in Gerrit has been merged, hence setting task status to resolved (via Add Action... → Change Status in the dropdown menu.)