| matmarex | |
| Oct 10 2017, 3:07 PM |
| F10119158: image.png | |
| Oct 10 2017, 3:07 PM |
mw.language.convertNumber() behavior for four-digit numbers is incorrect for Polish. The parser function {{formatnum:}} functions correctly. Four-digit numbers should not have a thousands separator (space) inserted after the first digit, only five-digit numbers (and longer).
I originally noticed this in the new RC filters:
To reproduce:
console.log( mw.language.convertNumber( 1000 ) );
| Input | Expected result | Current result | |
|---|---|---|---|
| 10 | 10 | 10 | |
| 100 | 100 | 100 | |
| 1000 | 1000 | 1 000 | ← WRONG |
| 10000 | 10 000 | 10 000 |
The PHP code's behavior is apparently implemented by custom code in LanguagePl::commafy(). We don't have any such system in the JS code yet. It seems that the same code block is copy-pasted to a dozen other languages too. Perhaps there is a sensible way to generalize this.
Change 383443 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Add test cases for digit grouping (commafy) in Polish
Change 383444 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Generalize non-digit-grouping of four-digit numbers
Change 383445 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mediawiki.language: Implement non-digit-grouping of four-digit numbers
Change 383443 merged by jenkins-bot:
[mediawiki/core@master] Add test cases for digit grouping (commafy) in Polish
@matmarex
Checked plwiki (wmf.4) - the fix is not there?
Btw, Preferences-Recent Changes "Number of edits to show" option verifies user input efficiently - giving warnings for negative, more than 1,000, or non-numeric values.
It is not fixed yet. Santhosh proposed a bigger rewrite of this code and I haven't had time to review it yet.
Change 383444 merged by jenkins-bot:
[mediawiki/core@master] Generalize non-digit-grouping of four-digit numbers
Patch https://gerrit.wikimedia.org/r/383445 is still waiting for review. The other two were preparation/refactoring, this one is needed to fix this.
Change 383445 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.language: Implement non-digit-grouping of four-digit numbers