Page MenuHomePhabricator

VE REL1_30 silently fails after any action which opens a dialogue window
Closed, ResolvedPublic0 Story Points

Description

http://www.wikidoc.org/index.php?title=Special:Version

Must be logged in to replicate issue, can provide account upon request.

Installed VE REL1_30 with Citoid, (citoid works great). Once the edit window opens, any action which is supposed to spawn a dialogue box will silently fail, no error message, just the impression of contempt.

Worked successfully before, at some point some users at random times would get their references helpfully deleted by older version of VE. Hoped upgrade would fix.

Upgrade did not fix. Software is broken :(

Please advise.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2017, 3:18 PM
UlfrTheRed updated the task description. (Show Details)Oct 10 2017, 3:25 PM

Thanks for the report. So we can take a look, please open your browser console and paste in here any errors that are shown.

Well, I would, except there aren't any. Console doesn't register anything, be it notice, script, log, or error.

Well, I would, except there aren't any. Console doesn't register anything, be it notice, script, log, or error.

If there's no console errors showing, then sadly I don't know what to suggest.

My team's focus is on Wikimedia wikis, so I don't have much time to look into third-party issues. If you create me an account, I can take a look when I have a bit of spare time. My contact information is on my user page.

Done. You should've recieved an e-mail with your username and password.

Well, I would, except there aren't any. Console doesn't register anything, be it notice, script, log, or error.

If there's no console errors showing, then sadly I don't know what to suggest.
My team's focus is on Wikimedia wikis, so I don't have much time to look into third-party issues. If you create me an account, I can take a look when I have a bit of spare time. My contact information is on my user page.

This error appears in my console when clicking the media dialogue:

jQuery.Deferred exception: OO.ui.CardLayout is not a constructor TypeError: OO.ui.CardLayout is not a constructor
    at VeUiMWMediaDialog.ve.ui.MWMediaDialog.initialize (<anonymous>:954:425)
    at VeUiMWMediaDialog.OO.ui.Window.setManager (<anonymous>:45:87)
    at VeUiSurfaceWindowManager.OO.ui.WindowManager.addWindows (<anonymous>:39:151)
    at VeUiSurfaceWindowManager.OO.ui.WindowManager.getWindow (<anonymous>:33:849)
    at https://www.wikidoc.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core&skin=vector&version=00b9t3e:626:170
    at fire (https://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:46:617)
    at Object.add [as done] (https://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:47:143)
    at Object.always (https://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:48:778)
    at https://www.wikidoc.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core&skin=vector&version=00b9t3e:626:138
    at mightThrow (https://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:49:598) undefined

Hey. The error jQuery.Deferred exception: OO.ui.CardLayout is not a constructor means you've got code that's trying to use CardLayout, which was removed (in a3bd7a94) in lieu of OO.ui.TabPanelLayout. That was removed from VisualEditor in f695877d, merged five months ago and definitely included in REL1_30.

It sounds like your loaded version of VisualEditor is older than REL1_30, though your Special:Version claims it's running 61f161a. Can you try restarting your Web server to see if it's caching things inappropriately?

Done.

Also amazed you got a response from this, I'm unable to get that to appear :(

I tried again, and I got a similar, but different, error:

load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:52 jQuery.Deferred exception: OO.ui.CardLayout is not a constructor TypeError: OO.ui.CardLayout is not a constructor
    at VeUiMWMediaDialog.ve.ui.MWMediaDialog.initialize (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.math.visualEditor%7Cext.templateData%7Cext.templateData.images%7Cext.templateDataGenerator.data%2CeditPage%2Cui%7Cext.templateDataGenerator.ui.images%7Cext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2ChackyIcons%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2Cmwalienextension%2Cmwcore%2Cmwdiffing%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignStructuredUpload%2CForeignUpload%2CUpload%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%2Cconfig%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.api.edit%2Cmessages%2Cupload%7Cmediawiki.diff.styles%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-wikimedia%2Cindicators%2Ctextures&skin=vector&version=1dthmpj:1779:425)
    at VeUiMWMediaDialog.OO.ui.Window.setManager (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.math.visualEditor%7Cext.templateData%7Cext.templateData.images%7Cext.templateDataGenerator.data%2CeditPage%2Cui%7Cext.templateDataGenerator.ui.images%7Cext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2ChackyIcons%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2Cmwalienextension%2Cmwcore%2Cmwdiffing%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignStructuredUpload%2CForeignUpload%2CUpload%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%2Cconfig%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.api.edit%2Cmessages%2Cupload%7Cmediawiki.diff.styles%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-wikimedia%2Cindicators%2Ctextures&skin=vector&version=1dthmpj:418:87)
    at VeUiSurfaceWindowManager.OO.ui.WindowManager.addWindows (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.math.visualEditor%7Cext.templateData%7Cext.templateData.images%7Cext.templateDataGenerator.data%2CeditPage%2Cui%7Cext.templateDataGenerator.ui.images%7Cext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2ChackyIcons%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2Cmwalienextension%2Cmwcore%2Cmwdiffing%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignStructuredUpload%2CForeignUpload%2CUpload%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%2Cconfig%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.api.edit%2Cmessages%2Cupload%7Cmediawiki.diff.styles%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-wikimedia%2Cindicators%2Ctextures&skin=vector&version=1dthmpj:412:151)
    at VeUiSurfaceWindowManager.OO.ui.WindowManager.getWindow (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.math.visualEditor%7Cext.templateData%7Cext.templateData.images%7Cext.templateDataGenerator.data%2CeditPage%2Cui%7Cext.templateDataGenerator.ui.images%7Cext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2ChackyIcons%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2Cmwalienextension%2Cmwcore%2Cmwdiffing%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignStructuredUpload%2CForeignUpload%2CUpload%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%2Cconfig%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.api.edit%2Cmessages%2Cupload%7Cmediawiki.diff.styles%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-wikimedia%2Cindicators%2Ctextures&skin=vector&version=1dthmpj:406:849)
    at http://www.wikidoc.org/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.math.visualEditor%7Cext.templateData%7Cext.templateData.images%7Cext.templateDataGenerator.data%2CeditPage%2Cui%7Cext.templateDataGenerator.ui.images%7Cext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2ChackyIcons%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2Cmwalienextension%2Cmwcore%2Cmwdiffing%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignStructuredUpload%2CForeignUpload%2CUpload%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%2Cconfig%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.api.edit%2Cmessages%2Cupload%7Cmediawiki.diff.styles%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-wikimedia%2Cindicators%2Ctextures&skin=vector&version=1dthmpj:1416:170
    at fire (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:46:617)
    at Object.add [as done] (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:47:143)
    at Object.always (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:48:778)
    at http://www.wikidoc.org/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.cite.style%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%7Cext.math.visualEditor%7Cext.templateData%7Cext.templateData.images%7Cext.templateDataGenerator.data%2CeditPage%2Cui%7Cext.templateDataGenerator.ui.images%7Cext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2ChackyIcons%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2Cmwalienextension%2Cmwcore%2Cmwdiffing%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwsignature%2Cmwtransclusion%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignStructuredUpload%2CForeignUpload%2CUpload%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%2Cconfig%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.api.edit%2Cmessages%2Cupload%7Cmediawiki.diff.styles%7Cmediawiki.language.names%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CStashedFileWidget%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-wikimedia%2Cindicators%2Ctextures&skin=vector&version=1dthmpj:1416:138
    at mightThrow (http://www.wikidoc.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=000t46t:49:598) undefined
Deskana moved this task from To Triage to Freezer on the VisualEditor board.Oct 10 2017, 6:33 PM

That different error is still sourced from CardLayout, which as Jdforrester-WMF mentioned isn't supposed to be loading for REL1_30 in the first place.

I'd be happy to show that the build is broken by disabling every extension on the site at your convenience, I just can't leave it that way for an extended period of time.

Error was unrelated to other extensions or javascript installations.

Issue was caused by an old install of MobileFrontend's recommended CSS rule, which sets the class Mobile to no display. The Mobile class is applied to any dialogues spawned. Thus, nothing shows.

Technically not an error.

UlfrTheRed closed this task as Resolved.Oct 17 2017, 2:40 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 17 2017, 2:40 PM
Deskana set the point value for this task to 0.Oct 17 2017, 2:42 PM