Begin testing the Reading List Service in the Android app:
https://github.com/wikimedia/restbase/pull/887
This probably requires setting up vagrant to test, see @Tgr for more information
Begin testing the Reading List Service in the Android app:
https://github.com/wikimedia/restbase/pull/887
This probably requires setting up vagrant to test, see @Tgr for more information
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix handling of partial order parameters | mediawiki/extensions/ReadingLists | master | +60 -22 | |
| Fix deleted row handling | mediawiki/extensions/ReadingLists | master | +204 -130 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tgr | T168985 Develop a Reading List Service | |||
| Resolved | Tgr | T168975 Develop a MediaWiki extension for managing Reading Lists | |||
| Resolved | Tgr | T181107 Deploy Reading Lists Service to production | |||
| Resolved | Tgr | T174651 Beta testing of the ReadingLists extension | |||
| Resolved | cooltey | T177853 Test integrating Android app with Reading List Service |
If you use vagrant, cherry-pick c380785 and parents, provision the readinglists role, and apply the RESTBase patches from the PR.
If you don't, install the ReadingLists extension in the usual way, and apply the relevant part of the vagrant role manually.
In case you haven't seen the comments in T168986: RL is available on beta and labs now:
@Tgr @Mholloway
For doing the test on https://readinglists.wmflabs.org/api/rest_v1/#/Reading_lists, which one is the best one to get the CSRF token?
Because I keep getting badtoken response on http://readinglists.wmflabs.org/api/rest_v1/#!/Reading_lists/post_data_lists_setup , and I believe something wrong with my testing steps.
You should be using the https://readinglists.wmflabs.org url, since this is the site on which you're logged in to test the reading lists.
One quick note about CSRF tokens: the API will give you a token that looks like 160341316df9190ce65fbce73830a2cb49f12890+\\, but the last two slashes are actually an escaped single slash, so the token that you'll pass into your next request should be 160341316df9190ce65fbce73830a2cb49f12890+\
Have some questions after doing the test on the https://readinglists.wmflabs.org/api/rest_v1/#/Reading_lists (using the "Try it now" tool)
Yeah, that's a bug. We use soft deletion and unique DB indexes so recreation will need special handling.
- Get an Integer value of name , and it happens in the following API. Should we get "name": "Planets" instead of "name": 0?
That will be fixed once https://gerrit.wikimedia.org/r/#/c/379702/ is merged. I guess I should just cherry-pick it to the test machine.
- Not sure how to use it, it returns 500 with the message List has been deleted
- /data/lists/changes/since/{date}
Can't see how that could happen. What user and URL did you get it with?
Nvm, that's also an older bug: https://gerrit.wikimedia.org/r/#/c/380695/
Will cherry-pick that as well.
The fix for all three issues is cherry-picked now. (The first is tracked in T179120.)
Have some questions after doing the test on the https://readinglists.wmflabs.org/api/rest_v1/#/Reading_lists (using the "Try it now" tool) - part 2
"title": "internal_api_error_LogicException" "detail": [616fe8d35a71832f541805f8] Exception caught: deleteListEntry failed for unknown reason
Change 387185 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Fix deleted row handling
Change 387186 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Fix handling of partial order parameters
@cooltey thanks for the thorough testing :) Those bugs should be fixed now.
Does it only support the en.wikipedia.org ? (because of the only testing purposes?)
At the moment, yes. (Although it should only affect the presence of the summaries.) I can add more domains if it's useful.
@Tgr Thanks!
At the moment, yes. (Although it should only affect the presence of the summaries.) I can add more domains if it's useful.
That would be great if you can also add es.wikipedia.org and also zh.wikipedia.org
Thanks, @Tgr.
All the APIs look good now except one minor question below:
Yeah, the list ID is not actually used for deletion (the backend API only takes an entry ID), it's only there because the URL hierarchy seemed more logical that way. Given that deletion URLs will never be cached, I don't think that can cause problems.
Change 387185 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix deleted row handling
Change 387186 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Fix handling of partial order parameters