Maximum CIDR range for blocks and CheckUser should match
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Huji
	Oct 10 2017, 4:58 PM

Description

The maximum size of a CIDR range for IPv4 is /16 for both blocks and CheckUser. However, for IPv6 this maximum is inconsistent:

CheckUser's config: $wgCheckUserCIDRLimit['IPv6'] = 32
Block config: $wgBlockCIDRLimit['IPv6'] = 19

Digging the code shows that the maximum for blocking used to /64 and was changed by @aaron in 8933e49ecd47 to /32 and quickly thereafter by @tstarling in dd1053bc49b6 to /19.

I think we should also allow CheckUser to use /19 by default, based on the same reasoning that Tim provided in dd1053bc49b6

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Changing $wgCheckUserCIDRLimit['IPv6'] from 32 to 19	mediawiki/extensions/CheckUser	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T171699: CheckUser should use methods from the IP class to validate IPs and CIDR ranges
Mentioned Here: rMW8933e49ecd47: Increased uselessly low $wgBlockCIDRLimit default for IPv6.
rMWdd1053bc49b6: Increase maximum IPv6 range block size to /19

Event Timeline

Huji created this task.Oct 10 2017, 4:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2017, 4:58 PM

Huji mentioned this in T171699: CheckUser should use methods from the IP class to validate IPs and CIDR ranges.Oct 10 2017, 4:58 PM

Change 383381 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/extensions/CheckUser@master] Changing $wgCheckUserCIDRLimit['IPv6'] from 32 to 19

https://gerrit.wikimedia.org/r/383381

gerritbot added a project: Patch-For-Review.Oct 10 2017, 5:00 PM

Huji claimed this task.Oct 10 2017, 5:01 PM

Huji triaged this task as Low priority.

Huji moved this task from Inbox to Patches for review on the CheckUser board.

Huji updated the task description. (Show Details)Oct 10 2017, 5:07 PM

Huji updated the task description. (Show Details)

Change 383381 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Changing $wgCheckUserCIDRLimit['IPv6'] from 32 to 19

https://gerrit.wikimedia.org/r/383381

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 13 2017, 12:00 AM