Page MenuHomePhabricator

Maximum CIDR range for blocks and CheckUser should match
Closed, ResolvedPublic

Description

The maximum size of a CIDR range for IPv4 is /16 for both blocks and CheckUser. However, for IPv6 this maximum is inconsistent:

CheckUser's config: $wgCheckUserCIDRLimit['IPv6'] = 32
Block config: $wgBlockCIDRLimit['IPv6'] = 19

Digging the code shows that the maximum for blocking used to /64 and was changed by @aaron in 8933e49ecd47 to /32 and quickly thereafter by @tstarling in dd1053bc49b6 to /19.

I think we should also allow CheckUser to use /19 by default, based on the same reasoning that Tim provided in dd1053bc49b6

Event Timeline

Huji created this task.Oct 10 2017, 4:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2017, 4:58 PM

Change 383381 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/extensions/CheckUser@master] Changing $wgCheckUserCIDRLimit['IPv6'] from 32 to 19

https://gerrit.wikimedia.org/r/383381

Huji claimed this task.Oct 10 2017, 5:01 PM
Huji triaged this task as Low priority.
Huji moved this task from Backlog to Patches in review on the CheckUser board.
Huji updated the task description. (Show Details)Oct 10 2017, 5:07 PM
Huji updated the task description. (Show Details)

Change 383381 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Changing $wgCheckUserCIDRLimit['IPv6'] from 32 to 19

https://gerrit.wikimedia.org/r/383381

Huji closed this task as Resolved.Oct 13 2017, 2:30 AM
Huji removed a project: Patch-For-Review.

Would Notice apply here? Is this the kind of stuff we would put in Tech News?