[1.31.0-wmf.2 ]&hidenondamaging=0 is ignored when "Show only likely problem edits" preference is enabled
Closed, ResolvedPublic
Actions

Description

Opt out of the new filters for RC
Enable the "Show only likely problem edits" preference for RC
Go to RC. See only bad edits. This is expected.
Click "Show probably good edits". The results don't change.

It looks like the preference is enabling the new-style ORES filters even if the new UI is disabled.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+21 -2	RCFilters: Don't let new params filter out old page

Customize query in gerrit

Event Timeline

Catrope created this task.Oct 10 2017, 8:41 PM

Restricted Application added projects: Collaboration-Team-Triage, Scoring-platform-team. · View Herald TranscriptOct 10 2017, 8:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Oct 10 2017, 8:44 PM

Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

SBisson added a subscriber: SBisson.Oct 11 2017, 3:02 PM

Etonkovidova renamed this task from &hidenondamaging=0 is ignored when "Show only likely problem edits" preference is enabled to [1.31.0-wmf.2 ]&hidenondamaging=0 is ignored when "Show only likely problem edits" preference is enabled.Oct 12 2017, 5:55 PM

Some puzzling results:
(1) enwiki with 1.31.0-wmf.2 displays the issue
(2) hewiki 1.31.0-wmf.3- the Preference-RC option "Show only likely problem edits" can be overridden with the RC page option " Show probably good edits".

(3) betalabs displays the issue

SBisson claimed this task.Oct 16 2017, 11:59 AM

SBisson moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 384504 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RCFilters: Don't let new params filter out old page

https://gerrit.wikimedia.org/r/384504

gerritbot added a project: Patch-For-Review.Oct 16 2017, 12:48 PM

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Oct 16 2017, 2:24 PM

Change 384504 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Don't let new params filter out old page

https://gerrit.wikimedia.org/r/384504

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Oct 17 2017, 7:05 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 17 2017, 8:00 PM

Halfak moved this task from Untriaged to Monitor on the Scoring-platform-team board.Oct 26 2017, 9:53 PM

Checked in wmf.6 - the fix is in place.

Etonkovidova closed this task as Resolved.Nov 8 2017, 12:25 AM