Page MenuHomePhabricator
Create Task
Maniphest T177893

Adyen jobs should retry at least once on connect failure
Closed, ResolvedPublic
Actions

Description

We're crashing out and sending failmail on the first connect timeout. It would be great to get the Adyen code to reuse some of the other http request stuff, but right now it's using some SOAP stuff from who-knows-where

Details

SubjectRepoBranchLines +/-
Add logging for debuggingwikimedia/fundraising/SmashPigmaster+2 -0
Demote error to warning, change WSwikimedia/fundraising/SmashPigmaster+15 -13
On exception, increase count and log errorwikimedia/fundraising/SmashPigmaster+40 -60
Add default value for processor_formmediawiki/extensions/DonationInterfacemaster+32 -6
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Oct 10 2017, 10:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2017, 10:51 PM
• DStrine added a project: FR-Adyen.Oct 12 2017, 8:06 PM
• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.
• DStrine moved this task from Sprint +3 to Sprint +1 on the Fundraising-Backlog board.Oct 20 2017, 5:36 PM
• mepps claimed this task.Oct 23 2017, 7:37 PM
• DStrine moved this task from Sprint +1 to Completed in Q2 2017-18 on the Fundraising-Backlog board.Oct 24 2017, 8:07 PM
• DStrine added a project: Fundraising Sprint Uptight Piano.Oct 24 2017, 8:21 PM
• mepps moved this task from Backlog to Doing on the Fundraising Sprint Uptight Piano board.Oct 31 2017, 4:55 PM
gerritbot subscribed.Nov 1 2017, 7:52 PM

Change 387858 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Add default value for processor_form

https://gerrit.wikimedia.org/r/387858

gerritbot added a project: Patch-For-Review.Nov 1 2017, 7:52 PM
gerritbot added a comment.Nov 1 2017, 9:09 PM

Change 387858 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Add default value for processor_form

https://gerrit.wikimedia.org/r/387858

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 1 2017, 10:00 PM
• mepps added a comment.Nov 2 2017, 3:54 PM

Oops! The merged task was supposed to be tagged to https://phabricator.wikimedia.org/T176913

• mepps moved this task from Doing to Review on the Fundraising Sprint Uptight Piano board.Nov 7 2017, 5:23 PM
• DStrine added a project: Fundraising Sprint Vaporwerewolf.Nov 7 2017, 5:40 PM
gerritbot added a comment.Nov 8 2017, 3:32 PM

Change 389998 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/SmashPig@master] On exception, increase count and log error

https://gerrit.wikimedia.org/r/389998

• mepps moved this task from Backlog to Review on the Fundraising Sprint Vaporwerewolf board.Nov 9 2017, 3:52 PM
gerritbot added a comment.Nov 9 2017, 8:37 PM

Change 389998 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] On exception, increase count and log error

https://gerrit.wikimedia.org/r/389998

gerritbot added a comment.Nov 9 2017, 8:49 PM

Change 390306 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Demote error to warning, change WS

https://gerrit.wikimedia.org/r/390306

gerritbot added a comment.Nov 9 2017, 8:52 PM

Change 390306 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Demote error to warning, change WS

https://gerrit.wikimedia.org/r/390306

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Vaporwerewolf board.Nov 13 2017, 8:48 PM
• DStrine added a project: Fundraising Sprint Winter Wanderland.Nov 21 2017, 9:38 PM
• mepps moved this task from Backlog to Pending Deployment on the Fundraising Sprint Winter Wanderland board.Nov 22 2017, 3:36 PM
• DStrine moved this task from Completed in Q2 2017-18 to Completed in Q3 2017-18 on the Fundraising-Backlog board.Jan 2 2018, 6:12 PM
• DStrine added a project: Fundraising Sprint Asymmetrical Earth Theory.Jan 2 2018, 9:19 PM
• mepps moved this task from Review to Pending Deployment on the Fundraising Sprint Uptight Piano board.Jan 5 2018, 3:07 PM
• mepps moved this task from Backlog to Pending Deployment on the Fundraising Sprint Asymmetrical Earth Theory board.
• mepps added a comment.Jan 5 2018, 4:22 PM

@Ejegg did we end up deploying this?

Ejegg added a comment.Jan 5 2018, 5:03 PM

We tried Tuesday, along with some other stuff, but there was an issue with the Amazon config that made us roll back. There's a fix for Amazon in review now, so hopefully we can deploy again next week.

Ejegg added a comment.Jan 5 2018, 5:05 PM

Also, do you think this might be related? T184200

gerritbot added a comment.Jan 8 2018, 5:21 PM

Change 402870 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/SmashPig@master] Add logging for debugging

https://gerrit.wikimedia.org/r/402870

gerritbot added a comment.Jan 8 2018, 6:51 PM

Change 402870 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add logging for debugging

https://gerrit.wikimedia.org/r/402870

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Asymmetrical Earth Theory board.Jan 8 2018, 7:21 PM
• mepps closed this task as Resolved.Jan 9 2018, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL