Page MenuHomePhabricator
Create Task
Maniphest T177980

ItemNotabilityFilter can't handle empty ItemId sets, query times out
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

We see the below error if the list of item ids passed to ItemNotabilityFilter::getItemsWithoutArticle is empty.

2017-10-11 14:30:33 [Wd4qhApAMF0AAEllNCMAAAAO] mw1258 bnwiki 1.31.0-wmf.2 exception ERROR: [Wd4qhApAMF0AAEllNCMAAAAO] …  Wikimedia\Rdbms\DBQueryError from line 1167 of /srv/mediawiki/php-1.31.0-wmf.2/includes/libs/rdbms/database/Database.php: A connection error occured.
Query: SELECT  ips_site_id,ips_site_page,ips_item_id  FROM `wb_items_per_site`    WHERE ips_site_id = 'bnwiki'
Function: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks
Error: 2013 Lost connection to MySQL server during query (10.64.48.25)
[Exception Wikimedia\Rdbms\DBQueryError] (/srv/mediawiki/php-1.31.0-wmf.2/includes/libs/rdbms/database/Database.php:1167) A connection error occured.
Query: SELECT  ips_site_id,ips_site_page,ips_item_id  FROM `wb_items_per_site`    WHERE ips_site_id = 'bnwiki'
Function: Wikibase\Lib\Store\Sql\SiteLinkTable::getLinks
Error: 2013 Lost connection to MySQL server during query (10.64.48.25)

  #0 /srv/mediawiki/php-1.31.0-wmf.2/includes/libs/rdbms/database/Database.php(979): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
  #1 /srv/mediawiki/php-1.31.0-wmf.2/includes/libs/rdbms/database/Database.php(1362): Wikimedia\Rdbms\Database->query(string, string)
  #2 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/SiteLinkTable.php(295): Wikimedia\Rdbms\Database->select(string, array, array, string)
  #3 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/CachingSiteLinkLookup.php(93): Wikibase\Lib\Store\Sql\SiteLinkTable->getLinks(array, array, array)
  #4 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/ArticlePlaceholder/includes/ItemNotabilityFilter.php(156): Wikibase\Lib\Store\CachingSiteLinkLookup->getLinks(array, array)
  #5 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/ArticlePlaceholder/includes/ItemNotabilityFilter.php(90): ArticlePlaceholder\ItemNotabilityFilter->getItemsWithoutArticle(array)
  #6 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(197): ArticlePlaceholder\ItemNotabilityFilter->getNotableEntityIds(array)
  #7 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(141): ArticlePlaceholder\SearchHookHandler->renderTermSearchResults(array)
  #8 /srv/mediawiki/php-1.31.0-wmf.2/extensions/Wikidata/extensions/ArticlePlaceholder/includes/SearchHookHandler.php(129): ArticlePlaceholder\SearchHookHandler->addToSearch(SpecialSearch, OutputPage, string)
  #9 /srv/mediawiki/php-1.31.0-wmf.2/includes/Hooks.php(177): ArticlePlaceholder\SearchHookHandler::onSpecialSearchResultsAppend(SpecialSearch, OutputPage, string)
  #10 /srv/mediawiki/php-1.31.0-wmf.2/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
  #11 /srv/mediawiki/php-1.31.0-wmf.2/includes/specials/SpecialSearch.php(459): Hooks::run(string, array)
  #12 /srv/mediawiki/php-1.31.0-wmf.2/includes/specials/SpecialSearch.php(185): SpecialSearch->showResults(string)
  #13 /srv/mediawiki/php-1.31.0-wmf.2/includes/specialpage/SpecialPage.php(522): SpecialSearch->execute(NULL)
  #14 /srv/mediawiki/php-1.31.0-wmf.2/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
  #15 /srv/mediawiki/php-1.31.0-wmf.2/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
  #16 /srv/mediawiki/php-1.31.0-wmf.2/includes/MediaWiki.php(851): MediaWiki->performRequest()
  #17 /srv/mediawiki/php-1.31.0-wmf.2/includes/MediaWiki.php(523): MediaWiki->main()
  #18 /srv/mediawiki/php-1.31.0-wmf.2/index.php(43): MediaWiki->run()
  #19 /srv/mediawiki/w/index.php(3): include(string)
  #20 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove empty array check before SiteLinkLookup callmediawiki/extensions/ArticlePlaceholdermaster+0 -4
Use null to mark no conditions in SiteLinkLookupmediawiki/extensions/Wikibasemaster+65 -83
Short-circuit in ItemNotabilityFilter if list of item ids is emptymediawiki/extensions/ArticlePlaceholdermaster+8 -0
Customize query in gerrit

Event Timeline

hoo created this task.Oct 11 2017, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2017, 6:53 PM
hoo added projects: Wikimedia-production-error, ArticlePlaceholder, Wikidata.Oct 11 2017, 6:53 PM
hoo moved this task from Incoming to Review on the ArticlePlaceholder board.
hoo added a project: Wikidata-Former-Sprint-Board.
hoo moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
hoo removed subscribers: Wikimedia-production-error, ArticlePlaceholder, Wikidata.
gerritbot subscribed.Oct 11 2017, 6:55 PM

Change 383637 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/ArticlePlaceholder@master] Short-circuit in ItemNotabilityFilter if list of item ids is empty

https://gerrit.wikimedia.org/r/383637

gerritbot added a project: Patch-For-Review.Oct 11 2017, 6:55 PM
thiemowmde triaged this task as Low priority.Oct 11 2017, 7:27 PM
thiemowmde removed a project: Patch-For-Review.
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Oct 11 2017, 7:37 PM

Change 383637 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Short-circuit in ItemNotabilityFilter if list of item ids is empty

https://gerrit.wikimedia.org/r/383637

hoo closed this task as Resolved.Oct 11 2017, 7:40 PM
hoo moved this task from Review to Done on the ArticlePlaceholder board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 11 2017, 8:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
gerritbot added a comment.Jul 20 2021, 12:01 PM

Change 705668 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use null to mark no conditions in SiteLinkLookup

https://gerrit.wikimedia.org/r/705668

gerritbot added a project: Patch-For-Review.Jul 20 2021, 12:01 PM
gerritbot added a comment.Jul 20 2021, 1:27 PM

Change 705680 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Remove empty array check before SiteLinkLookup call

https://gerrit.wikimedia.org/r/705680

gerritbot added a comment.Aug 4 2021, 5:13 PM

Change 705668 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use null to mark no conditions in SiteLinkLookup

https://gerrit.wikimedia.org/r/705668

gerritbot added a comment.Aug 5 2021, 7:31 AM

Change 705680 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Remove empty array check before SiteLinkLookup call

https://gerrit.wikimedia.org/r/705680

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits