Add a checkbox below globalized preferences that permits them to have local exceptions to the global values. The global page should also note that there is a local exception.
See for details: https://meta.wikimedia.org/wiki/Community_Tech/Global_preferences#Local_exceptions
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Local overrides for global prefs | mediawiki/extensions/GlobalPreferences | master | +170 -35 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Samwilson | T178267 Dynamically enable/disable the related pref when toggling "Set a local exception for this global preference" | |||
| Resolved | Samwilson | T178044 Add local exceptions to global prefs | |||
| Resolved | Samwilson | T68869 Update Global preferences UI | |||
| Resolved | Samwilson | T173476 Investigation: Figure out what needs to be rewritten in GlobalPreferences | |||
| Resolved | Samwilson | T178449 RFC: How to modify all preferences? |
Change 383304 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Local overrides for global prefs
This is not yet complete, but a partially-working demo is now live on the CommTech wiki: https://commtech.wmflabs.org./wiki/Special:Preferences
There are various issues, but most are tracked by subsequent tasks that will be done after the current code is merged:
All the current task is for is to get the basic functionality working: can you set a global pref and then override it locally? And then unset it either locally or globally and have the expected happen?
Patch for review: https://gerrit.wikimedia.org/r/#/c/383304
Live on commtech test wiki: https://commtech.wmflabs.org./wiki/Special:Preferences
The comments above (T178044#3749983) still stand.
When a global pref has a local exception, and the global pref is made not global any more and then made global again, do you expect the local exception to still exist? Or should it have gone away when the global flag was removed?
If the local exception status should be retained, should the help text appear dynamically when the global flag is turned back on? Or just on the next page load?
Change 383304 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Local overrides for global prefs
When a global pref has a local exception, and the global pref is made not global any more and then made global again, do you expect the local exception to still exist? Or should it have gone away when the global flag was removed?
If the local exception status should be retained, should the help text appear dynamically when the global flag is turned back on? Or just on the next page load?
As it could only ever act on the local exceptions on the current wiki, it seems that the correct answer here is that it should not remove the local-exception flag when unglobalizing a preference (this is how it now works).