Page MenuHomePhabricator
Create Task
Maniphest T178112

GUI allows to run empty query
Closed, ResolvedPublic
Actions

Description

If I go to query.wikidata.org and just click "run" button without entering anything, the GUI would happily run empty query. I think it'd be better if it didn't try to run it until something has been entered

Details

ProjectBranchLines +/-Subject
wikidata/query/guimaster+1 -1Remove extra text-center class
wikidata/query/gui-deployproduction+33 -32Merging from eeeb286cdd9bd43123b492ac5430e16886f2b8fa:
wikidata/query/guimaster+47 -12Disallow empty query from running by showing an error message
wikidata/query/guimaster+40 -14Disallow empty query from running by showing an error message
Customize query in gerrit

Related Objects

Event Timeline

Smalyshev created this task.Oct 12 2017, 8:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2017, 8:53 PM
• Jonas added a comment.Oct 12 2017, 9:01 PM

It could show the cat query by default, just kidding :)

Seriously, maybe in addition to not penetrate the service with empty queries,
we could give some nice text and maybe also a button to open examples dialog.

Lucas_Werkmeister_WMDE added a comment.Oct 13 2017, 9:02 AM

What we need to watch out for is how the browser behaves when reopening a closed tab or something like that – I’ve run into a few websites where in such a situation the text area is still filled in (because the browser restored it), but the UI isn’t updated, so it still behaves as if required input was missing (in our case, this might mean the “run query” button would still be disabled).

• Jonas moved this task from Backlog to Bugs on the Wikidata Query UI board.Dec 4 2017, 10:16 AM
Lydia_Pintscher added a project: Wikidata.Dec 4 2017, 2:26 PM
thiemowmde triaged this task as Low priority.Dec 5 2017, 4:10 PM
gerritbot added a subscriber: gerritbot.Mar 11 2018, 7:35 PM

Change 418723 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Prssanna):
[wikidata/query/gui@master] Disallow empty query from running by showing an error message

https://gerrit.wikimedia.org/r/418723

gerritbot added a project: Patch-For-Review.Mar 11 2018, 7:35 PM
• Jonas mentioned this in rWDQG278d0d79c003: Disallow empty query from running by showing an error message.Mar 11 2018, 7:38 PM
• Jonas assigned this task to prssanna.Mar 12 2018, 9:46 AM
• Jonas moved this task from Bugs to Doing on the Wikidata Query UI board.
gerritbot added a comment.Mar 12 2018, 11:31 AM

Change 418888 had a related patch set uploaded (by Prssanna; owner: Prssanna):
[wikidata/query/gui@master] Disallow empty query from running by showing an error message

https://gerrit.wikimedia.org/r/418888

prssanna mentioned this in rWDQG7b6b30db4580: Disallow empty query from running by showing an error message.Mar 12 2018, 11:32 AM
prssanna mentioned this in rWDQG097d7c01bf99: Disallow empty query from running by showing an error message.Mar 12 2018, 11:51 AM
gerritbot added a comment.Mar 12 2018, 11:53 AM

Change 418888 abandoned by Prssanna:
Disallow empty query from running by showing an error message

https://gerrit.wikimedia.org/r/418888

prssanna mentioned this in rWDQG887f303e9573: Disallow empty query from running by showing an error message.Mar 12 2018, 3:08 PM
prssanna mentioned this in rWDQGeeeb286cdd9b: Disallow empty query from running by showing an error message.Mar 13 2018, 2:06 PM
• Jonas added a comment.Mar 14 2018, 10:20 AM

This is how it will look:

image.png (873×1 px, 68 KB)

• Jonas moved this task from Doing to Done on the Wikidata Query UI board.Mar 14 2018, 10:22 AM
gerritbot added a comment.Mar 14 2018, 10:23 AM

Change 418723 merged by jenkins-bot:
[wikidata/query/gui@master] Disallow empty query from running by showing an error message

https://gerrit.wikimedia.org/r/418723

Lucas_Werkmeister_WMDE added a comment.Mar 14 2018, 10:50 AM
In T178112#3682230, @Lucas_Werkmeister_WMDE wrote:

What we need to watch out for is how the browser behaves when reopening a closed tab or something like that – I’ve run into a few websites where in such a situation the text area is still filled in (because the browser restored it), but the UI isn’t updated, so it still behaves as if required input was missing (in our case, this might mean the “run query” button would still be disabled).

Seems to work fine :)

Lydia_Pintscher added a project: Wikidata-Ministry-Of-Magic.Mar 14 2018, 12:04 PM
prssanna mentioned this in T189669: Proposal: Improve Explorer Dialog and Graph Explorer for query.wikidata.org .Mar 14 2018, 12:23 PM
• Jonas moved this task from Tasks to Done on the Wikidata-Ministry-Of-Magic board.Mar 14 2018, 1:12 PM
gerritbot added a comment.Mar 15 2018, 6:29 AM

Change 419660 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/gui-deploy@production] Merging from eeeb286cdd9bd43123b492ac5430e16886f2b8fa:

https://gerrit.wikimedia.org/r/419660

gerritbot added a comment.Mar 15 2018, 6:32 AM

Change 419660 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from eeeb286cdd9bd43123b492ac5430e16886f2b8fa:

https://gerrit.wikimedia.org/r/419660

Lucas_Werkmeister_WMDE added a comment.Mar 21 2018, 12:50 PM

Well, this is how timeouts look now:

Screenshot-2018-3-21 Wikidata Query Service.png (923×1 px, 151 KB)

I don’t usually expect exception stack traces to look like poetry ;)

• Jonas closed this task as Resolved.Mar 21 2018, 12:53 PM
gerritbot added a comment.Mar 21 2018, 12:56 PM

Change 421007 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Remove extra text-center class

https://gerrit.wikimedia.org/r/421007

Lucas_Werkmeister_WMDE mentioned this in rWDQGf394512e3ce4: Remove extra text-center class.Mar 21 2018, 1:01 PM
gerritbot added a comment.Mar 21 2018, 5:57 PM

Change 421007 merged by jenkins-bot:
[wikidata/query/gui@master] Remove extra text-center class

https://gerrit.wikimedia.org/r/421007

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL