Page MenuHomePhabricator

Update flake8-docstrings version and remove pydocstyle version restriction from tox.ini
Closed, ResolvedPublic

Description

To resolve T177912 we pinned the version of pydocstyle to 2.0.0. We should remove that restriction and update the minimum requirement of flake8-docstrings after they fix the issue.

The related issue upstream is: https://gitlab.com/pycqa/flake8-docstrings/issues/23

Event Timeline

Dalba created this task.Oct 13 2017, 7:07 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptOct 13 2017, 7:07 AM
Dalba moved this task from Backlog to Upstream issues on the Pywikibot board.Oct 13 2017, 7:08 AM
Dalba triaged this task as Low priority.
Dalba updated the task description. (Show Details)Oct 13 2017, 7:13 AM
Xqt added a subscriber: Xqt.Oct 13 2017, 11:02 AM

Change 401908 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] Remove pydocstyle version restriction

https://gerrit.wikimedia.org/r/401908

jayvdb added a subscriber: jayvdb.Jan 4 2018, 9:06 AM

Note that this change is removing the existing, working, __all__ checking. It likely brings in new features and bugs fixes, so probably is worth that, but then we need to get __all__ checking working again.

jayvdb added a comment.Jan 4 2018, 9:29 AM

c.f. https://github.com/PyCQA/pydocstyle/pull/227 - this __all__ problem shouldnt exist in pydocstyle. (I'm still investigating, and this doesnt impact the current CR)

Change 401908 merged by jenkins-bot:
[pywikibot/core@master] Remove pydocstyle version restriction

https://gerrit.wikimedia.org/r/401908

jayvdb closed this task as Resolved.Jan 4 2018, 10:43 AM