Page MenuHomePhabricator
Create Task
Maniphest T178149

RunCommandMonitoringProtocol throws an exception if runcommand.arguments is not specified
Closed, ResolvedPublic
Actions

Description

Setting up a runcommand monitor fails if runcommand.arguments is not specified in RunCommand's configuration:

Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 588, in _runCallbacks
Oct 12 13:13:41 lvs1003 pybal[28500]: current.result = callback(current.result, *args, **kw)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/pybal/coordinator.py", line 163, in _ready
Oct 12 13:13:41 lvs1003 pybal[28500]: self.createMonitoringInstances(coordinator)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/pybal/coordinator.py", line 212, in createMonitoringInstances
Oct 12 13:13:41 lvs1003 pybal[28500]: monitor = monitorclass(coordinator, self, lvsservice.configuration)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/pybal/monitors/runcommand.py", line 120, in __init__
Oct 12 13:13:41 lvs1003 pybal[28500]: self.arguments = self._getConfigStringList('arguments', locals=locals)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/pybal/monitor.py", line 129, in _getConfigStringList
Oct 12 13:13:41 lvs1003 pybal[28500]: val = eval(self.configuration[key], locals, globals)
Oct 12 13:13:41 lvs1003 pybal[28500]: exceptions.KeyError: 'runcommand.arguments'
Oct 12 13:13:41 lvs1003 pybal[28500]: Unhandled error in Deferred:
Oct 12 13:13:41 lvs1003 pybal[28500]: Traceback (most recent call last):
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 588, in _runCallbacks
Oct 12 13:13:41 lvs1003 pybal[28500]: current.result = callback(current.result, *args, **kw)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 859, in _cbDeferred
Oct 12 13:13:41 lvs1003 pybal[28500]: self.callback(self.resultList)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 393, in callback
Oct 12 13:13:41 lvs1003 pybal[28500]: self._startRunCallbacks(result)
Oct 12 13:13:41 lvs1003 pybal[28500]: File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 501, in _startRunCallbacks
Oct 12 13:13:41 lvs1003 pybal[28500]: self._runCallbacks()

If runcommand.arguments is not specified, PyBal should default to [""] instead.

Details

SubjectRepoBranchLines +/-
1.14.2: do not crash on empty runcommand.argumentsoperations/debs/pybalmaster+7 -0
1.14.2: do not crash on empty runcommand.argumentsoperations/debs/pybal1.14+7 -0
runcommand: do not crash on empty runcommand.argumentsoperations/debs/pybalmaster+39 -1
runcommand: do not crash on empty runcommand.argumentsoperations/debs/pybal1.14+39 -1
hieradata: force present and empty runcommand.argumentsoperations/puppetproduction+4 -0
Customize query in gerrit

Related Objects

Event Timeline

• ema created this task.Oct 13 2017, 9:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2017, 9:57 AM
• ema triaged this task as Medium priority.Oct 13 2017, 9:58 AM
gerritbot subscribed.Oct 13 2017, 9:58 AM

Change 383997 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] hieradata: force present and empty runcommand.arguments

https://gerrit.wikimedia.org/r/383997

gerritbot added a project: Patch-For-Review.Oct 13 2017, 9:58 AM

Change 384000 had a related patch set uploaded (by Ema; owner: Ema):
[operations/debs/pybal@master] runcommand: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384000

gerritbot added a comment.Oct 13 2017, 10:14 AM

Change 383997 merged by Filippo Giunchedi:
[operations/puppet@production] hieradata: force present and empty runcommand.arguments

https://gerrit.wikimedia.org/r/383997

Stashbot subscribed.Oct 13 2017, 10:22 AM

Mentioned in SAL (#wikimedia-operations) [2017-10-13T10:22:48Z] <godog> roll-restart pybal to apply https://gerrit.wikimedia.org/r/#/c/383997/ - T178149

• ema moved this task from Backlog to LoadBalancer on the Traffic board.Oct 13 2017, 2:28 PM
gerritbot added a comment.Oct 16 2017, 9:32 AM

Change 384000 merged by Ema:
[operations/debs/pybal@master] runcommand: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384000

gerritbot added a comment.Oct 16 2017, 9:33 AM

Change 384480 had a related patch set uploaded (by Ema; owner: Ema):
[operations/debs/pybal@1.14] runcommand: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384480

gerritbot added a comment.Oct 16 2017, 9:34 AM

Change 384480 merged by Ema:
[operations/debs/pybal@1.14] runcommand: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384480

gerritbot added a comment.Oct 16 2017, 9:36 AM

Change 384483 had a related patch set uploaded (by Ema; owner: Ema):
[operations/debs/pybal@master] 1.14.2: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384483

gerritbot added a comment.Oct 16 2017, 9:38 AM

Change 384483 merged by Ema:
[operations/debs/pybal@master] 1.14.2: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384483

gerritbot added a comment.Oct 16 2017, 9:38 AM

Change 384484 had a related patch set uploaded (by Ema; owner: Ema):
[operations/debs/pybal@1.14] 1.14.2: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384484

gerritbot added a comment.Oct 16 2017, 9:38 AM

Change 384484 merged by Ema:
[operations/debs/pybal@1.14] 1.14.2: do not crash on empty runcommand.arguments

https://gerrit.wikimedia.org/r/384484

Stashbot added a comment.Oct 16 2017, 9:44 AM

Mentioned in SAL (#wikimedia-operations) [2017-10-16T09:44:49Z] <ema> upgrading ulsfo LVSs to pybal 1.14.2 (T178149, T177815)

Stashbot mentioned this in T177815: Alerts on LVS services with one single realserver.Oct 16 2017, 9:44 AM
Stashbot added a comment.Oct 16 2017, 9:54 AM

Mentioned in SAL (#wikimedia-operations) [2017-10-16T09:54:33Z] <ema> upgrading esams LVSs to pybal 1.14.2 (T178149, T177815)

Stashbot added a comment.Oct 16 2017, 10:03 AM

Mentioned in SAL (#wikimedia-operations) [2017-10-16T10:03:13Z] <ema> upgrading codfw LVSs to pybal 1.14.2 (T178149, T177815)

Stashbot added a comment.Oct 16 2017, 12:38 PM

Mentioned in SAL (#wikimedia-operations) [2017-10-16T12:38:38Z] <ema> upgrading eqiad LVSs to pybal 1.14.2 (T178149, T177815)

• ema closed this task as Resolved.Oct 16 2017, 12:46 PM
• ema claimed this task.

PyBal upgraded to 1.14.2 on all LVS hosts.

fgiunchedi mentioned this in T178078: RESTBase logs disappeared from logstash.Oct 19 2017, 8:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL