[BUG] Regression – "Search results from your Offline Library' is shown in Dark mode colors when in Light mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Oct 13 2017, 11:19 AM

Description

This appears to be a regression of item implemented in T166649.

Expected

Search - offline from compilation.png (1×720 px, 70 KB)

Actual

Steps to reproduce

Pre-requisite: User has at least one article pack in their Offline Library and app is displayed in Light mode

Turn on airplane mode
Tap to search Wikipedia

Detected on

Tested on Nexus (6.0.1), Wikipedia v2.6.203-alpha-2017-10-12

Details

	Subject	Repo	Branch	Lines +/-
	Design tweak: fix color theming when searching offline library.	apps/android/wikipedia	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned Here: T166649: Notify users searching whilst offline that results are limited to available offline articles

Event Timeline

RHo created this task.Oct 13 2017, 11:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2017, 11:19 AM

Change 384056 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Design tweak: fix color theming when searching offline library.

https://gerrit.wikimedia.org/r/384056

gerritbot added a project: Patch-For-Review.Oct 13 2017, 2:41 PM

Dbrant claimed this task.Oct 13 2017, 2:41 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.21x-Enchilada on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada); removed Wikipedia-Android-App-Backlog.

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada). · View Herald TranscriptOct 13 2017, 2:41 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.21x-Enchilada on the Wikipedia-Android-App-Backlog board.Oct 13 2017, 2:42 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.

Change 384056 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweak: fix color theming when searching offline library.

https://gerrit.wikimedia.org/r/384056

Dbrant moved this task from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 13 2017, 8:03 PM

LGTM

Tested on 5.1 ZTE Maven (Z812) and Wikipedia app 2.6.205-alpha-2017-10-27. Below are screencaps of search Wikipedia in Dark and Light modes on the ZTE, both appear to be as expected.

Hi @Nicholas.tsg - actually this is missing pre-requisite which requires firstly that the user has at least one article pack downloaded to their Offline Library so that the expected message "Search results from your Offline Library" appears below the search bar.

Here are steps to fulfil the pre-requisite requirement:

Go to the Offline Library by selecting the overflow menu item on the Explore feed.
Tap the action to 'Add' to Offline library which bring up a list of all packs available for download
Tap on the overflow menu of an article pack and select the option to "Download". It is expected that UI for the download in progress (comprising a progress bar, estimated remaining time & data, pause and cancel actions) should display below the relevant list item.
Once the download completes tap to go back to the Explore feed.

Dbrant moved this task from QA Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 30 2017, 4:14 PM

Dbrant closed this task as Resolved.Oct 30 2017, 4:15 PM

	F8857494: Search - offline from compilation.png
	Oct 13 2017, 11:19 AM

	F10505607: T178156 Dark.png
	Oct 29 2017, 8:25 PM

	F10505606: T178156 Light.png
	Oct 29 2017, 8:25 PM

	F10416266: image.png
	Oct 24 2017, 6:22 PM

[BUG] Regression – "Search results from your Offline Library' is shown in Dark mode colors when in Light modeClosed, ResolvedPublicActions