Page MenuHomePhabricator
Create Task
Maniphest T178181

selectFields() methods are deprecated
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Various selectFields() methods were deprecated in MediaWiki core change
Idcfd1556.

They are used in the Mobile History page (and possibly other places)

To avoid this page breaking we need to review and update existing usages

Details

SubjectRepoBranchLines +/-
Update for deprecation of selectFields() methodsmediawiki/extensions/MobileFrontendmaster+12 -3
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Oct 13 2017, 4:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2017, 4:58 PM
gerritbot subscribed.Oct 13 2017, 4:59 PM

Change 383921 had a related patch set uploaded (by Jdlrobson; owner: Anomie):
[mediawiki/extensions/MobileFrontend@master] Update for deprecation of selectFields() methods

https://gerrit.wikimedia.org/r/383921

gerritbot added a project: Patch-For-Review.Oct 13 2017, 4:59 PM
Jdlrobson triaged this task as High priority.Oct 13 2017, 4:59 PM
Jdlrobson edited projects, added Readers-Web-Kanbanana-Board-Old; removed Patch-For-Review.

Pulling into sprint for visibility

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 13 2017, 5:39 PM
Jdlrobson added a project: MobileFrontend.Oct 13 2017, 5:57 PM
ovasileva moved this task from Triaged but Future to 2017-18 Q2 on the Web-Team-Backlog board.Oct 16 2017, 9:21 AM
ovasileva moved this task from Needs Code Review to To Do on the Readers-Web-Kanbanana-Board-Old board.Oct 17 2017, 4:27 PM
ovasileva set the point value for this task to 2.Oct 17 2017, 4:30 PM
gerritbot added a comment.Oct 17 2017, 4:39 PM

Change 383921 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update for deprecation of selectFields() methods

https://gerrit.wikimedia.org/r/383921

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 17 2017, 5:00 PM
Jdlrobson closed this task as Resolved.Oct 17 2017, 5:25 PM
Jdlrobson claimed this task.
Jdlrobson moved this task from To Do to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

I accidentally merged this by relying to confidently on the Depends-On field...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL