| cooltey | |
| Oct 13 2017, 9:18 PM |
| F16748626: image.png | |
| Apr 6 2018, 12:51 PM |
| F10190863: consistance2.png | |
| Oct 13 2017, 9:18 PM |
| F10190861: consistence.png | |
| Oct 13 2017, 9:18 PM |
(same issue happens in "zh-hans" language code)
Tab title are inconsistent (you can see the red circles below)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • JMinor | T195265 As a Chinese reader, I want better control of which character set I see zh wiki content in | |||
| Resolved | BUG REPORT | • JMinor | T176901 [BUG] Unable to switch between Chinese language variants using the article language picker | ||
| Resolved | cooltey | T149027 Item titles in search result should respect user's variant settings | |||
| Resolved | BUG REPORT | None | T178201 [BUG] Incorrect variant issues on Tab title | ||
| Resolved | cooltey | T182928 [BUG] Preview dialog title shows incorrect Chinese variants |
Is the root of the issue related to T149027? IIRC, the original title an article is created is getting shown in search results and previews without being converted to the user set variant.
Change 424477 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Showing incorrect article title in the reading lists
@RHo
Yes, it is. We cannot update the original title that shows on the search results before loading the leading section.
hi @cooltey - I just ran the test and now the incorrect variant title is showing not only on the tab, but also on the article title itself, which is even worse than the inconsistency in the tab bar since now the main article content is showing incorrectly.
Recommend reverting this change until the root issue T149027 is solved.
Unexpected result - Main article title now shows in the wrong (simplified) variant on the article itself:
@RHo
Please see my comment in https://phabricator.wikimedia.org/T191629#4112485
And regarding to the screenshot you have, please see the ticket T191580
Before testing the issue for this ticket, please log out your Wikipedia account.
hey @cooltey - so I logged out and cleared cache so the title now matches the content. However, now the original bug remains where the text in the tab bar and dialog text does not match article text.
See the demo here: https://youtu.be/Rv8Q4EzB5dc
@RHo
Yes, my patch (https://gerrit.wikimedia.org/r/#/c/424477/) is still in CodeReview, and it fixes the issue of the Tab titledoes not match the article title but does not fix the ContextMenu Dialog issue.
Change 472751 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Chinese variants issues that title in the lists does not match the article itself
Change 472751 abandoned by Dbrant:
Fix: Chinese variants issues that title in the lists does not match the article itself
Reason:
currently on github
Updated the task description since we've changed a context dialog to a popup menu, and there's no title will be shown on the popup menu.