Figure handler rejects nested tables in figure captions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bdijkstra
	Oct 15 2017, 4:11 PM

Description

Non-nested table

[subbu@earth parsoid] echo "[[File:Foo.jpg|thumb|180px|Foo<br/>\n{|\n|x\n|}\n]]" | parse.js --normalize
<figure><a href="File:Foo.jpg"><img src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" data-file-width="300" data-file-height="197" data-file-type="bitmap" height="118" width="180"/></a><figcaption>Foo<br/>
<table>
<tbody>
<tr>
<td>x</td>
</tr>
</tbody>
</table>
</figcaption></figure>

Nested table (the table is missing in the output)

[subbu@earth parsoid] echo "[[File:Foo.jpg|thumb|180px|Foo<br/>\n{|\n|\n{|\n|z\n|}\n|}\n]]" | parse.js --normalize
<figure><a href="File:Foo.jpg"><img src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" data-file-width="300" data-file-height="197" data-file-type="bitmap" height="118" width="180"/></a><figcaption>} </figcaption></figure>

----Original bug report ----
When an image caption contains a wikitable, the linter may flag bogus-image-options while everything on the page looks "as intended".

Examples:

There is nothing to fix, so these cases are false positives.

Related Objects

Mentioned In: T179259: Visual Editor removing whitespace from infoboxes by default
T180930: When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serialization
T61840: jsdiff uses excessive time / memory on pages with a lot of lines
T179757: Linter/tidy-font-bug triggers on empty font tags
T171381: Fix missing-end-tag linter issue generation
T180010: Parsoid creates broken wikitext for link inside square brackets
T173643: Create Wiktionary Fiji Hindi
Mentioned Here: rGPAR01c1fc33c15c: Improve parameter aliases handling when ordering template parameters
T61840: jsdiff uses excessive time / memory on pages with a lot of lines
T179259: Visual Editor removing whitespace from infoboxes by default
T180930: When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serialization
rGPARe71937d03430: Rename stx_v data-parsoid flag to stx
rGPAR2887b5adf392: Bump to domino@2.0.0
T171381: Fix missing-end-tag linter issue generation
T173643: Create Wiktionary Fiji Hindi
T179757: Linter/tidy-font-bug triggers on empty font tags
T180010: Parsoid creates broken wikitext for link inside square brackets

Event Timeline

Bdijkstra created this task.Oct 15 2017, 4:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2017, 4:11 PM

Bdijkstra renamed this task from LintError bogus-image-options false positves with wikitable syntax to LintError bogus-image-options false positives with wikitable syntax.Oct 15 2017, 4:12 PM

Bdijkstra updated the task description. (Show Details)

Parsoid is having trouble recognizing nested tables in figure captions. This is a tokenizer problem and not a linter issue per se.

[subbu@earth parsoid] echo "[[File:Foo.jpg|thumb|180px|Foo<br/>\n{|\n|x\n|}\n]]" | parse.js --normalize --lint
<figure><a href="File:Foo.jpg"><img src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" data-file-width="300" data-file-height="197" data-file-type="bitmap" height="118" width="180"/></a><figcaption>Foo<br/>
<table>
<tbody>
<tr>
<td>x</td>
</tr>
</tbody>
</table>
</figcaption></figure>
[subbu@earth parsoid] echo "[[File:Foo.jpg|thumb|180px|Foo<br/>\n{|\n|\n{|\n|z\n|}\n|}\n]]" | parse.js --normalize --lint
<figure><a href="File:Foo.jpg"><img src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" data-file-width="300" data-file-height="197" data-file-type="bitmap" height="118" width="180"/></a><figcaption>} </figcaption></figure>
[info/lint/bogus-image-options][enwiki/Main Page] {"type":"bogus-image-options","params":{"items":["Foo<br/>\n{|\n|\n{|\n|z\n|}\n"]},"dsr":[0,55,2,2]}

ssastry renamed this task from LintError bogus-image-options false positives with wikitable syntax to Figure handler rejects nested tables in figure captions.Oct 15 2017, 6:27 PM

ssastry triaged this task as Medium priority.

ssastry edited projects, added Parsoid; removed MediaWiki-extensions-Linter.

ssastry updated the task description. (Show Details)

I thought this was not a parser issue as I saw no differences in the parsermigration tool. Could someone please explain this for my understanding?

In T178253#3686043, @Bdijkstra wrote:

I thought this was not a parser issue as I saw no differences in the parsermigration tool. Could someone please explain this for my understanding?

Parsermigration uses output from the PHP parser and fixes HTML with Tidy and Remex and those are two versions you see.

Linter warnings are not based on PHP parser -- they use Parsoid's analysis. So, if Parsoid and PHP parser differ, then you can get false positives reported compared to what you see in the parsermigration tool.

Thanks!

ssastry added a project: Parsoid-Tokenizer.Nov 6 2017, 6:35 PM

Arlolra claimed this task.Nov 6 2017, 7:59 PM

Change 389553 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T178253: Parse nested tables in figure captions

https://gerrit.wikimedia.org/r/389553

gerritbot added a project: Patch-For-Review.Nov 6 2017, 8:37 PM

Change 389553 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T178253: Parse nested tables in figure captions

https://gerrit.wikimedia.org/r/389553

Arlolra closed this task as Resolved.Nov 6 2017, 10:19 PM

Mentioned in SAL (#wikimedia-operations) [2017-11-09T18:41:16Z] <arlolra> Updated Parsoid to 2887b5ad (T178253, T173643, T176728, T180010, T171381, T179757)

Stashbot mentioned this in T173643: Create Wiktionary Fiji Hindi.Nov 9 2017, 6:41 PM

Stashbot mentioned this in T180010: Parsoid creates broken wikitext for link inside square brackets.

Stashbot mentioned this in T171381: Fix missing-end-tag linter issue generation.

Stashbot mentioned this in T179757: Linter/tidy-font-bug triggers on empty font tags.

Hmm, so after purging,

https://nl.wikipedia.org/api/rest_v1/page/html/Heuvelland_(Zuid-Limburg)

is fixed.

But,

https://nl.wikipedia.org/api/rest_v1/page/html/Klimaatclassificatie_van_K%C3%B6ppen

is not. Same locally so looks like there's some more work to do here.

Change 390348 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T178253: Handle pipe ending table attributes in figure captions

https://gerrit.wikimedia.org/r/390348

Change 390348 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T178253: Handle pipe ending table attributes in figure captions

https://gerrit.wikimedia.org/r/390348

Arlolra closed this task as Resolved.Nov 13 2017, 11:25 PM

Mentioned in SAL (#wikimedia-operations) [2017-11-14T18:32:12Z] <arlolra> Updated Parsoid to e71937d0 (T178253)

https://nl.wikipedia.org/api/rest_v1/page/html/Klimaatclassificatie_van_K%C3%B6ppen looks good after a purge

Found some more nested tables on other wikis, this one didn't disappear after a purge:

https://ru.wikipedia.org/api/rest_v1/page/html/Хронология_первых_космических_запусков_по_странам

Change 391360 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T178253: Permit table rows from templates in figure captions

https://gerrit.wikimedia.org/r/391360

In T178253#3760741, @Bdijkstra wrote:

Found some more nested tables on other wikis, this one didn't disappear after a purge:

https://ru.wikipedia.org/api/rest_v1/page/html/Хронология_первых_космических_запусков_по_странам

Thanks!

The nested table there looks like this,

[[Файл:Orbital Launches.svg|thumb|right|250px|Космические державы
{| style="width:100%;" |- | valign=top |
{{legend|#ff3232|Признанные запуски РН}}
{{legend|#3200ff|Неподтверждённые запуски РН}}
{{legend|#008000|Планирующиеся запуски РН}}
|}
]]

which expands to,

{| style="width:100%;" |- | valign=top |
<div class="legend" style="-webkit-column-break-inside: avoid;page-break-inside: avoid;break-inside: avoid-column"><span class="legend-color" style="display:inline-block; width:1.5em; height:1.5em; margin:1px 0; border:1px solid black; background-color:
#ff3232; color:black; font-size:100%; text-align:center;">&nbsp;</span>&nbsp;Признанные запуски РН</div>
<div class="legend" style="-webkit-column-break-inside: avoid;page-break-inside: avoid;break-inside: avoid-column"><span class="legend-color" style="display:inline-block; width:1.5em; height:1.5em; margin:1px 0; border:1px solid black; background-color:
#3200ff; color:black; font-size:100%; text-align:center;">&nbsp;</span>&nbsp;Неподтверждённые запуски РН</div>
<div class="legend" style="-webkit-column-break-inside: avoid;page-break-inside: avoid;break-inside: avoid-column"><span class="legend-color" style="display:inline-block; width:1.5em; height:1.5em; margin:1px 0; border:1px solid black; background-color:
#008000; color:black; font-size:100%; text-align:center;">&nbsp;</span>&nbsp;Планирующиеся запуски РН</div>
|}

which is a bunch of fosterable content. However, there's still something to fix here as seen in the reduced test case in the above patch.

Change 391360 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T178253: Permit table rows from templates in figure captions

https://gerrit.wikimedia.org/r/391360

Mentioned in SAL (#wikimedia-operations) [2017-12-06T21:43:17Z] <arlolra> Updated Parsoid to rGPAR01c1fc33c15c (T178253, T61840, T180930, T179259)

Stashbot mentioned this in T61840: jsdiff uses excessive time / memory on pages with a lot of lines.Dec 6 2017, 9:43 PM

Stashbot mentioned this in T180930: When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serialization.

Stashbot mentioned this in T179259: Visual Editor removing whitespace from infoboxes by default.

We now get the expected render at https://ru.wikipedia.org/api/rest_v1/page/html/%D0%A5%D1%80%D0%BE%D0%BD%D0%BE%D0%BB%D0%BE%D0%B3%D0%B8%D1%8F_%D0%BF%D0%B5%D1%80%D0%B2%D1%8B%D1%85_%D0%BA%D0%BE%D1%81%D0%BC%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D1%85_%D0%B7%D0%B0%D0%BF%D1%83%D1%81%D0%BA%D0%BE%D0%B2_%D0%BF%D0%BE_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B0%D0%BC

Figure handler rejects nested tables in figure captionsClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Figure handler rejects nested tables in figure captions
Closed, ResolvedPublic
Actions