Moved here from https://github.com/wikisource/ia-upload/issues/15 (to keep all issues in one place):
There should be an option if user not to convert djvu #15
There should be an option if user not to convert djvu, only upload pdf.
Moved here from https://github.com/wikisource/ia-upload/issues/15 (to keep all issues in one place):
There should be an option if user not to convert djvu #15
There should be an option if user not to convert djvu, only upload pdf.
This seems more useful in light of T182470, where PDFs without text layers are not able to be turned into DjVu by the /phetools/pdf_to_djvu_cgi.py tool. It's becoming less clear as time goes on why we want to turn PDFs into DjVus anyway!
I think we could:
I think that'd be about the minimum required to satisfy this task.
(@satdeep_gill does this sound like roughly what we talked about?)
"It's becoming less clear as time goes on why we want to turn PDFs into DjVus anyway!"
Probably just history: https://en.wikisource.org/wiki/Wikisource:DjVu_vs._PDF
I've edited that page a bit, to update the section about advantages of DjVu.
I wonder what it'd take to add a "Get PDF from IA" option to UploadWizard, in a similar vein to the Flickr upload option? Given that PDFs from IA don't need any processing, it might be nicer to make it more integrated into Commons.
@kamholz the login is now doing a strange redirection to port 8000, e.g. https://ia-upload-test.toolforge.org:8000/oauth/init?referer=http%3A%2F%2Fia-upload-test.toolforge.org%3A8000%2F do you know why that might be?
Must be an issue with views/template.twig, where it does this:
{{ 'login-notice'|message( full_url_for( 'oauth-init', [], {'referer': (get_uri().__toString())} ) )|raw }}
It seems to be detecting the URL wrong in both full_url_for and get_uri. See docs at https://github.com/slimphp/Twig-View
I think I see a fix for this, but you'll have to test it on toolforge -- shall I submit another PR on GitHub?
Yep, send a PR. I've also added you as a maintainer on ia-upload-test, so you can log in there and try things out. https://toolsadmin.wikimedia.org/tools/id/ia-upload-test