Page MenuHomePhabricator
Create Task
Maniphest T178324

VE's context menus are badly broken in beta
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
matmarex
Authored By
Deskana
Oct 16 2017, 6:39 PM
Tags
Referenced Files
F10280914: Screen Shot 2017-10-17 at 2.32.24 PM.png
Oct 17 2017, 7:36 PM
F10265139: image.png
Oct 16 2017, 8:06 PM
F10263952: Screen Shot 2017-10-16 at 19.38.00.png
Oct 16 2017, 6:39 PM
F10263946: Screen Shot 2017-10-16 at 19.38.42.png
Oct 16 2017, 6:39 PM
F10263950: Screen Shot 2017-10-16 at 19.38.32.png
Oct 16 2017, 6:39 PM
F10263948: Screen Shot 2017-10-16 at 19.38.37.png
Oct 16 2017, 6:39 PM
Subscribers
Aklapper
Deskana
Esanders
gerritbot
Jay8g
Jdforrester-WMF
Ryasmeen
View All 10 Subscribers

Description

Screen Shot 2017-10-16 at 19.38.42.png (782×880 px, 435 KB)

Screen Shot 2017-10-16 at 19.38.37.png (494×852 px, 41 KB)

Screen Shot 2017-10-16 at 19.38.32.png (262×870 px, 22 KB)

Screen Shot 2017-10-16 at 19.38.00.png (288×854 px, 43 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Citoidwmf/1.31.0-wmf.4+2 -1ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI
mediawiki/extensions/Citoidmaster+2 -1ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI
mediawiki/extensions/VisualEditormaster+1 -1Update VE core submodule to master (ea5179857)
VisualEditor/VisualEditormaster+7 -4Fix CSS for context menus after changes in OOjs UI
Customize query in gerrit

Related Objects

Event Timeline

Deskana created this task.Oct 16 2017, 6:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2017, 6:39 PM
Deskana triaged this task as Unbreak Now! priority.Oct 16 2017, 6:39 PM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptOct 16 2017, 6:39 PM
matmarex claimed this task.Oct 16 2017, 7:01 PM
gerritbot added a subscriber: gerritbot.Oct 16 2017, 7:20 PM

Change 384583 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Fix CSS for context menus after changes in OOjs UI

https://gerrit.wikimedia.org/r/384583

gerritbot added a project: Patch-For-Review.Oct 16 2017, 7:20 PM
gerritbot added a comment.Oct 16 2017, 7:59 PM

Change 384583 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix CSS for context menus after changes in OOjs UI

https://gerrit.wikimedia.org/r/384583

gerritbot added a comment.Oct 16 2017, 8:05 PM

Change 384594 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b20086541)

https://gerrit.wikimedia.org/r/384594

Esanders added a subscriber: Esanders.Oct 16 2017, 8:06 PM

Apex still broken:

image.png (112×413 px, 10 KB)

matmarex added a comment.Oct 16 2017, 8:27 PM

That actually looks like a distinct issue, and a bug in OOjs UI itself rather than an interaction with our CSS. I'll file a separate task.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Oct 16 2017, 8:28 PM
In T178324#3688829, @matmarex wrote:

That actually looks like a distinct issue, and a bug in OOjs UI itself rather than an interaction with our CSS. I'll file a separate task.

Might be related to T178251 ?

Volker_E added a subscriber: Volker_E.EditedOct 16 2017, 8:31 PM

@Jdforrester-WMF Yes, it is! Patch was provided yesterday evening.

matmarex added a comment.Oct 16 2017, 8:36 PM

Might be, although the description there doesn't mention this specific issue. The patch there might apply to it too though. I filed T178336: In Apex theme, any iconless widget placed inside any iconed widget renders incorrectly.

gerritbot added a comment.Oct 16 2017, 8:54 PM

Change 384607 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.LinearContextItem: Workaround for T178324

https://gerrit.wikimedia.org/r/384607

gerritbot added a comment.Oct 16 2017, 10:10 PM

Change 384594 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ea5179857)

https://gerrit.wikimedia.org/r/384594

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Oct 16 2017, 10:27 PM
Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.

Looks Resolved to me.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 16 2017, 11:00 PM
Deskana closed this task as Resolved.Oct 17 2017, 3:02 PM
Deskana set the point value for this task to 1.

Thanks!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 17 2017, 3:02 PM
Ryasmeen reopened this task as Open.Oct 17 2017, 7:36 PM
Ryasmeen added a subscriber: Ryasmeen.

This is still reproducible for Add Citation context menu

Screen Shot 2017-10-17 at 2.32.24 PM.png (276×548 px, 43 KB)

gerritbot added a comment.Oct 17 2017, 8:27 PM

Change 384792 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Citoid@master] ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI

https://gerrit.wikimedia.org/r/384792

gerritbot added a project: Patch-For-Review.Oct 17 2017, 8:27 PM
gerritbot added a comment.Oct 17 2017, 8:37 PM

Change 384792 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI

https://gerrit.wikimedia.org/r/384792

gerritbot added a comment.Oct 17 2017, 8:40 PM

Change 384817 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/Citoid@wmf/1.31.0-wmf.4] ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI

https://gerrit.wikimedia.org/r/384817

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)); removed MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 17 2017, 9:00 PM
Deskana closed this task as Resolved.Oct 17 2017, 9:35 PM

Fixed in master now.

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Oct 17 2017, 9:43 PM
gerritbot added a comment.Oct 17 2017, 11:14 PM

Change 384817 merged by jenkins-bot:
[mediawiki/extensions/Citoid@wmf/1.31.0-wmf.4] ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI

https://gerrit.wikimedia.org/r/384817

Stashbot added a subscriber: Stashbot.Oct 17 2017, 11:31 PM

Mentioned in SAL (#wikimedia-operations) [2017-10-17T23:31:15Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.4/extensions/Citoid/modules/ve.ui.CiteFromIdInspector.css: SWAT: [[gerrit:384817|ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI]] T178324 (duration: 00m 50s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 18 2017, 12:00 AM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Oct 18 2017, 5:12 AM
Ryasmeen added a project: Verified-in-Phase0.Oct 18 2017, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL