Page MenuHomePhabricator

Prevent Email Blacklist from saving an empty row in the database
Closed, ResolvedPublic

Description

If you do not specify an email blacklist, but save your user preferences, you'll get an empty pref in the database.

Event Timeline

dbarratt created this task.Oct 16 2017, 8:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2017, 8:49 PM

Change 384610 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Prevent an empty database record for email-blacklist

https://gerrit.wikimedia.org/r/384610

@dbarratt — does this ticket need to be updated, given your work on zeros in notifications mute?

@TBolliger I've updated the patch. This is ready to be reviewed/merged.

Anything I can do to help get it reviewed?

This may have been fixed in T117781#4595049

TBolliger closed this task as Resolved.Mar 7 2019, 6:57 PM
TBolliger claimed this task.

Confirmed fixed on local dev env