Page MenuHomePhabricator

jQuery.IME broken in Two column edit conflict
Closed, InvalidPublic

Description

Steps to reproduce:

  1. Enable 'Two column edit conflict' from Beta features.
  2. Get edit conflict (to test, probably use different username or co-ordinate with other user is the only way to do this?)
  3. jQuery.IME will be broken like we saw in the T176104

Event Timeline

Restricted Application added a project: TCB-Team. · View Herald TranscriptOct 17 2017, 7:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hey @KartikMistry, thanks for the feedback.

Get edit conflict (to test, probably use different username or co-ordinate with other user is the only way to do this?)

Yes, for the beta testing we provide a special page[1] where you can simulate an edit conflict to get to the two column conflict view without much hassle.[2]

jQuery.IME will be broken like we saw in the T176104

We will look into it, might be, that some hooks are not executed correctly on the two column conflict page.

[1] e.g. https://en.wikipedia.org/wiki/Special:SimulateTwoColEditConflict
[2] see as well https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/Edit_Conflicts/Feedback_Round_Test_Page

WMDE-Fisch added a comment.EditedOct 24 2017, 12:44 PM

Ok it's me again. I just tried to reproduce it by looking at the steps in the ticket linked ( T176104 ). I adjusted the steps to use the conflict simulation page

  • Open https://kn.wikipedia.org/wiki/Special:SimulateTwoColEditConflict
  • Choose some random article to simulate the conflict with ( e.g. ಕೊಂಕಣ_ಸೇನ್_ಶರ್ಮಾ )
  • Click on Create Conflict ( there's no Kannada translation yet ;-) )
  • Dismiss all dialogs and focus the editor
  • Select any Kannada keyboard layout in the editor from ULS to KGP/Nudi/KP Rao
  • Type any word in Kannada, for ex., [k][n][f][n][w]

When I follow the steps above I get the result expected as stated in T176104 ಕನ್ನಡ

P.S.: I do all that with the system keyboard layout en-us. I am not sure if that's relevant for jQuery.IME

Edit: Also I am using Firefox

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-10-17 board.

Ok it's me again. I just tried to reproduce it by looking at the steps in the ticket linked ( T176104 ). I adjusted the steps to use the conflict simulation page

  • Open https://kn.wikipedia.org/wiki/Special:SimulateTwoColEditConflict
  • Choose some random article to simulate the conflict with ( e.g. ಕೊಂಕಣ_ಸೇನ್_ಶರ್ಮಾ )
  • Click on Create Conflict ( there's no Kannada translation yet ;-) )
  • Dismiss all dialogs and focus the editor
  • Select any Kannada keyboard layout in the editor from ULS to KGP/Nudi/KP Rao
  • Type any word in Kannada, for ex., [k][n][f][n][w]

When I follow the steps above I get the result expected as stated in T176104 ಕನ್ನಡ

This seems working for me too! :)

P.S.: I do all that with the system keyboard layout en-us. I am not sure if that's relevant for jQuery.IME
Edit: Also I am using Firefox

en-us is fine. I tried Chrome (stable) and result is same, so we can close this bug.

Tobi_WMDE_SW closed this task as Invalid.Nov 2 2017, 8:49 AM
Tobi_WMDE_SW added a subscriber: Tobi_WMDE_SW.

@KartikMistry Thank's for reporting back! I'm closing the ticket now.

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Nov 14 2017, 3:28 PM