Page MenuHomePhabricator
Create Task
Maniphest T178357

Don't use protocol relative links to Commons in MultimediaViewer
Open, Needs TriagePublic
Actions

Description

On some occasions, MMV still suggests protocol relative rules to Commons. E.g.

  1. Go to https://en.wikipedia.org/wiki/Wikipedia#/media/File:History_Comparison_Example_(Vector).png
  2. Click the download icon.
  3. Click "You need to attribute the author"
  4. Click "HTML"
  5. Copy the code.

You get: By Cody Brittain (<a href="//commons.wikimedia.org/wiki/User:Cbrittain10" title="User:Cbrittain10">Cbrittain10</a>) - Wikipedia, <a href="https://creativecommons.org/licenses/by-sa/3.0" title="Creative Commons Attribution-Share Alike 3.0">CC BY-SA 3.0</a>, <a href="https://commons.wikimedia.org/w/index.php?curid=31349187">Link</a>

If you use this code somewhere with https, the protocol relative URL is equivalent to https://commons.wikimedia.org/wiki/User:Cbrittain10, if you use it with http, you'll just get redirected to the same URL.

So the protocol relative URLs no longer make sense and should be replaced with explicit https.

Related Objects
Search...

Event Timeline

Schnark created this task.Oct 17 2017, 9:21 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 17 2017, 9:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex edited projects, added CommonsMetadata; removed MediaViewer.Oct 17 2017, 8:39 PM
matmarex subscribed.

Looks like MultimediaViewer simply gets this data from the API and displays it as-is:

https://en.wikipedia.org/w/api.php?action=query&format=jsonfm&prop=imageinfo&titles=File%3AHistory_Comparison_Example_(Vector)%2Epng&iiprop=timestamp%7Curl%7Csize%7Cmime%7Cmediatype%7Cextmetadata&iiextmetadatafilter=DateTime%7CDateTimeOriginal%7CObjectName%7CImageDescription%7CLicense%7CLicenseShortName%7CUsageTerms%7CLicenseUrl%7CCredit%7CArtist%7CAuthorCount%7CGPSLatitude%7CGPSLongitude%7CPermission%7CAttribution%7CAttributionRequired%7CNonFree%7CRestrictions%7CDeletionReason&iiextmetadatalanguage=en&uselang=content&smaxage=300&maxage=300

I'm moving this to CommonsMetadata but if we dig deeper, I suspect we might discover that the protocol-relative link actually comes from somewhere in our configuration.

Tgr subscribed.Oct 17 2017, 9:07 PM

The links come from File::getDescriptionText() which just fetches https://commons.wikimedia.org/wiki/File:History_Comparison_Example_(Vector).png?action=render. So this has something to with internal link parsing (and specifically this horrible thing).

matmarex added a comment.Oct 17 2017, 9:10 PM

So, the root cause here is that $wgServer on Commons is set to "//commons.wikimedia.org" while arguably it should be "https://commons.wikimedia.org".

Or possibly that code should be using $wgCanonicalServer…?

Tgr added a comment.Oct 17 2017, 9:28 PM

Yeah; that's T118413: Wikimedia wikis should use https:// in $wgServer.

IMO using $wgServer is correct; when the server does support both protocols, you want the URLs in the description (and rendered pages in general) to be relative.

matmarex renamed this task from Don't use protocol relative links to Commons to Don't use protocol relative links to Commons in MultimediaViewer.Oct 17 2017, 9:43 PM
matmarex edited projects, added WMF-General-or-Unknown; removed CommonsMetadata.
matmarex added a subtask: T118413: Wikimedia wikis should use https:// in $wgServer.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL