Page MenuHomePhabricator

Consider having a light source casting shadows in the 3D viewer
Closed, ResolvedPublic


See how nice this looks:

Compared to this:

It clearly makes the object more "legible", and thus more useful from an encyclopedic perspective.


Related Gerrit Patches:
mediawiki/extensions/3D : masterMake textures better match style guide
3d2png : masterImprove 3D display
mediawiki/extensions/3D : masterImprove 3D display

Event Timeline

Gilles created this task.Oct 17 2017, 9:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2017, 9:55 AM

Yeah, I think we can greatly improve what objects look like, and I would prefer to attempt to nail it now that it's not yet deployed.

I've been messing around with textures, lights, etc for a bit, trying to get close to the example above (see examples below)
I also noticed the example image was smoothened - we could also do that, but probably shouldn't as it can cause some artifacts (see smoothened phone image)

currentchange in colors & lightssmoothened

@Nirzar what do you think?

Change 386193 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] [WIP] Improve 3D display

Yeah the shape smoothing is introducing significant artifacts on the phone example and I don't think it's a good idea for encyclopedic purposes.

The color and lights update are definitely an improvement, as they make details appear that are "burned" in the current way of displaying things. And the shadows improve the depth perception.

TheDJ added a subscriber: TheDJ.Nov 9 2017, 10:39 AM

Like the colors, but be careful with keeping a good contrast difference of background and object. Contrast is the most important part of accessibility for visual impaired audiences.

I changed a few things:

  • shadows are less harsh
  • the color is slightly less yellow, more grey-ish
  • the object is slightly more shiny and light reflects a bit more off of it

How does that look?

TheDJ added a comment.Nov 13 2017, 1:22 PM

I like it :)

matmarex updated the task description. (Show Details)Nov 13 2017, 3:13 PM

Change 391581 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[3d2png@master] Improve 3D display

@matthiasmullie I gave a verbal okay during a stand-up a little while ago. Just wanted to be explicit here that I think this looks good!

Change 386193 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Improve 3D display

Looks pretty good. I tried on a couple operating systems a bunch of browsers. Shading appears to be working.

The smoothing is definitely looking better than earlier... thanks @matthiasmullie

Change 391581 merged by MarkTraceur:
[3d2png@master] Improve 3D display

ABorbaWMF closed this task as Resolved.Nov 21 2017, 5:57 PM

Change 408499 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Make textures better match style guide

Change 408499 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Make textures better match style guide