| • Gilles | |
| Oct 17 2017, 9:55 AM |
| F10909087: Screen Shot 2017-11-20 at 5.27.20 PM.png | |
| Nov 21 2017, 1:30 AM |
| F10909088: Screen Shot 2017-11-20 at 5.19.55 PM.png | |
| Nov 21 2017, 1:30 AM |
| F10766393: image.png | |
| Nov 13 2017, 3:13 PM |
| F10766391: image.png | |
| Nov 13 2017, 3:13 PM |
| F10764463: Screenshot 2017-11-13 13.12.51.png | |
| Nov 13 2017, 12:19 PM |
| F10764464: Screenshot 2017-11-13 13.13.04.png | |
| Nov 13 2017, 12:19 PM |
| F10413506: np-smooth.png | |
| Oct 24 2017, 2:21 PM |
| F10413507: np-shadow.png | |
| Oct 24 2017, 2:21 PM |
See how nice this looks:
https://sketchfab.com/models/9a4f5906879449c4b6d845d9bb04c9e7#
Compared to this:
https://commons.wikimedia.beta.wmflabs.org/wiki/File:Asad_Al-Lat.stl#/media/File:Asad_Al-Lat.stl
It clearly makes the object more "legible", and thus more useful from an encyclopedic perspective.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make textures better match style guide | mediawiki/extensions/3D | master | +1 -1 | |
| Improve 3D display | 3d2png | master | +23 -21 | |
| Improve 3D display | mediawiki/extensions/3D | master | +12 -9 |
Yeah, I think we can greatly improve what objects look like, and I would prefer to attempt to nail it now that it's not yet deployed.
I've been messing around with textures, lights, etc for a bit, trying to get close to the example above (see examples below)
I also noticed the example image was smoothened - we could also do that, but probably shouldn't as it can cause some artifacts (see smoothened phone image)
| current | change in colors & lights | smoothened |
 |  |  |
 |  |  |
@Nirzar what do you think?
Change 386193 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] [WIP] Improve 3D display
Yeah the shape smoothing is introducing significant artifacts on the phone example and I don't think it's a good idea for encyclopedic purposes.
The color and lights update are definitely an improvement, as they make details appear that are "burned" in the current way of displaying things. And the shadows improve the depth perception.
Like the colors, but be careful with keeping a good contrast difference of background and object. Contrast is the most important part of accessibility for visual impaired audiences.
 |  |
I changed a few things:
How does that look?
Change 391581 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[3d2png@master] Improve 3D display
@matthiasmullie I gave a verbal okay during a stand-up a little while ago. Just wanted to be explicit here that I think this looks good!
Change 386193 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Improve 3D display
Looks pretty good. I tried on a couple operating systems a bunch of browsers. Shading appears to be working.
Change 408499 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Make textures better match style guide
Change 408499 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Make textures better match style guide